From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: kosaki.motohiro@jp.fujitsu.com,
MinChan Kim <minchan.kim@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Christoph Lameter <cl@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/4] Reclaim page capture v4
Date: Fri, 3 Oct 2008 12:25:56 +0900 (JST) [thread overview]
Message-ID: <20081003122332.EF58.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20081002150423.GG11089@brain>
> > I tested your patch in my desktop.
> > The test is just kernel compile with single thread.
> > My system environment is as follows.
> >
> > model name : Intel(R) Core(TM)2 Quad CPU Q6600 @ 2.40GHz
> > MemTotal: 2065856 kB
> >
> > When I tested vanilla, compile time is as follows.
> >
> > 2433.53user 187.96system 42:05.99elapsed 103%CPU (0avgtext+0avgdata
> > 0maxresident)k
> > 588752inputs+4503408outputs (127major+55456246minor)pagefaults 0swaps
> >
> > When I tested your patch, as follows.
> >
> > 2489.63user 202.41system 44:47.71elapsed 100%CPU (0avgtext+0avgdata
> > 0maxresident)k
> > 538608inputs+4503928outputs (130major+55531561minor)pagefaults 0swaps
> >
> > Regresstion almost is above 2 minutes.
> > Do you think It is a trivial?
> >
> > I know your patch is good to allocate hugepage.
> > But, I think many users don't need it, including embedded system and
> > desktop users yet.
> >
> > So I suggest you made it enable optionally.
>
> Hmmm. I would not expect to see any significant impact for this kind of
> workload as we should not be triggering capture for the lower order
> allocations at all. Something screwey must be occuring. I will go and
> reproduce this here and see if I can figure out just what causes this.
yup.
I also think this is significant regression.
if this is reproduced, that patch shouldn't be merged to -mm, IMHO.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-03 3:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 12:30 Andy Whitcroft
2008-10-01 12:30 ` [PATCH 1/4] pull out the page pre-release and sanity check logic for reuse Andy Whitcroft
2008-10-02 7:05 ` KAMEZAWA Hiroyuki
2008-10-01 12:30 ` [PATCH 2/4] pull out zone cpuset and watermark checks " Andy Whitcroft
2008-10-02 7:05 ` KAMEZAWA Hiroyuki
2008-10-01 12:31 ` [PATCH 3/4] buddy: explicitly identify buddy field use in struct page Andy Whitcroft
2008-10-02 7:06 ` KAMEZAWA Hiroyuki
2008-10-01 12:31 ` [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer Andy Whitcroft
2008-10-01 15:01 ` Christoph Lameter
2008-10-02 14:35 ` Andy Whitcroft
2008-10-02 16:29 ` Christoph Lameter
2008-10-03 3:41 ` KOSAKI Motohiro
2008-10-03 12:37 ` Christoph Lameter
2008-10-02 7:24 ` KAMEZAWA Hiroyuki
2008-10-02 15:02 ` Andy Whitcroft
2008-10-02 15:25 ` kamezawa.hiroyu
2008-10-02 2:46 ` [PATCH 0/4] Reclaim page capture v4 MinChan Kim
2008-10-02 15:04 ` Andy Whitcroft
2008-10-03 3:25 ` KOSAKI Motohiro [this message]
2008-10-03 6:48 ` KOSAKI Motohiro
2008-10-07 4:29 ` MinChan Kim
2008-10-02 6:44 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003122332.EF58.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=nickpiggin@yahoo.com.au \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox