Re: 2.6.27-rc8 hot memory remove panic

[Yasunori Goto <y-goto@jp.fujitsu.com>]

> On Thu, 2008-10-02 at 10:23 -0700, Badari Pulavarty wrote:
> > Hi,
> > 
> > Ran into this while testing hotplug memory remove on 2.6.27-rc8.
> > Never saw this earlier.
> > 
> > Any ideas on whats happening.
> > 
> > put_page_bootmem():
> >         BUG_ON(type >= -1);
> 
> 
> It looks like we have undocumented dependency on CONFIG_NUMA=y to get
> hotplug memory remove working.
> 
> register_page_bootmem_info_node() gets called only if 
> CONFIG_NEED_MULTIPLE_NODES=y which gets selected only if CONFIG_NUMA=y.

Oops. My bad....

I remember its dependency is removed from Kconfig some month ago.
Then, register_page_bootmem_info_node() should be called when CONFIG_NUMA
is off.
Is this patch enough?

---

register_page_bootmem_info_node() should be called for memory hot-remove
even when CONFIG_NUMA is off.

Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>

---
 mm/bootmem.c |    1 +
 1 file changed, 1 insertion(+)

Index: current/mm/bootmem.c
===================================================================
--- current.orig/mm/bootmem.c	2008-10-03 09:58:58.000000000 +0900
+++ current/mm/bootmem.c	2008-10-03 11:57:21.000000000 +0900
@@ -222,6 +222,7 @@ unsigned long __init free_all_bootmem_no
  */
 unsigned long __init free_all_bootmem(void)
 {
+	register_page_bootmem_info_node(NODE_DATA(0));
 	return free_all_bootmem_core(NODE_DATA(0)->bdata);
 }
 

-- 
Yasunori Goto 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>