From: Andy Whitcroft <apw@shadowen.org>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer
Date: Thu, 2 Oct 2008 15:35:08 +0100 [thread overview]
Message-ID: <20081002143508.GE11089@brain> (raw)
In-Reply-To: <48E390DA.9060109@linux-foundation.org>
On Wed, Oct 01, 2008 at 10:01:46AM -0500, Christoph Lameter wrote:
> Andy Whitcroft wrote:
> > When a process enters direct reclaim it will expend effort identifying
> > and releasing pages in the hope of obtaining a page. However as these
> > pages are released asynchronously there is every possibility that the
> > pages will have been consumed by other allocators before the reclaimer
> > gets a look in. This is particularly problematic where the reclaimer is
> > attempting to allocate a higher order page. It is highly likely that
> > a parallel allocation will consume lower order constituent pages as we
> > release them preventing them coelescing into the higher order page the
> > reclaimer desires.
>
> The reclaim problem is due to the pcp queueing right? Could we disable pcp
> queueing during reclaim? pcp processing is not necessarily a gain, so
> temporarily disabling it should not be a problem.
>
> At the beginning of reclaim just flush all pcp pages and then do not allow pcp
> refills again until reclaim is finished?
Not entirely, some pages could get trapped there for sure. But it is
parallel allocations we are trying to guard against. Plus we already flush
the pcp during reclaim for higher orders.
-apw
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-02 14:35 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 12:30 [PATCH 0/4] Reclaim page capture v4 Andy Whitcroft
2008-10-01 12:30 ` [PATCH 1/4] pull out the page pre-release and sanity check logic for reuse Andy Whitcroft
2008-10-02 7:05 ` KAMEZAWA Hiroyuki
2008-10-01 12:30 ` [PATCH 2/4] pull out zone cpuset and watermark checks " Andy Whitcroft
2008-10-02 7:05 ` KAMEZAWA Hiroyuki
2008-10-01 12:31 ` [PATCH 3/4] buddy: explicitly identify buddy field use in struct page Andy Whitcroft
2008-10-02 7:06 ` KAMEZAWA Hiroyuki
2008-10-01 12:31 ` [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer Andy Whitcroft
2008-10-01 15:01 ` Christoph Lameter
2008-10-02 14:35 ` Andy Whitcroft [this message]
2008-10-02 16:29 ` Christoph Lameter
2008-10-03 3:41 ` KOSAKI Motohiro
2008-10-03 12:37 ` Christoph Lameter
2008-10-02 7:24 ` KAMEZAWA Hiroyuki
2008-10-02 15:02 ` Andy Whitcroft
2008-10-02 15:25 ` kamezawa.hiroyu
2008-10-02 2:46 ` [PATCH 0/4] Reclaim page capture v4 MinChan Kim
2008-10-02 15:04 ` Andy Whitcroft
2008-10-03 3:25 ` KOSAKI Motohiro
2008-10-03 6:48 ` KOSAKI Motohiro
2008-10-07 4:29 ` MinChan Kim
2008-10-02 6:44 ` KAMEZAWA Hiroyuki
-- strict thread matches above, loose matches on Subject: below --
2008-09-05 10:19 [PATCH 0/4] Reclaim page capture v3 Andy Whitcroft
2008-09-05 10:20 ` [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer Andy Whitcroft
2008-09-03 18:44 [RFC PATCH 0/4] Reclaim page capture v2 Andy Whitcroft
2008-09-03 18:44 ` [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer Andy Whitcroft
2008-09-03 20:35 ` Christoph Lameter
2008-09-03 20:53 ` Andy Whitcroft
2008-09-03 21:00 ` Christoph Lameter
2008-09-04 6:38 ` Peter Zijlstra
2008-09-04 14:18 ` Christoph Lameter
2008-09-04 8:11 ` KOSAKI Motohiro
2008-09-04 8:58 ` Andy Whitcroft
2008-09-04 7:20 ` Peter Zijlstra
2008-09-04 11:35 ` Andy Whitcroft
2008-09-04 7:59 ` KOSAKI Motohiro
2008-09-04 14:44 ` Andy Whitcroft
2008-09-05 1:52 ` KOSAKI Motohiro
2008-07-01 17:58 [RFC PATCH 0/4] Reclaim page capture v1 Andy Whitcroft
2008-07-01 17:58 ` [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer Andy Whitcroft
2008-07-02 12:01 ` KOSAKI Motohiro
2008-07-02 14:44 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002143508.GE11089@brain \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=nickpiggin@yahoo.com.au \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox