From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 26 Sep 2008 18:59:44 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 3/12] memcg make root cgroup unlimited. Message-Id: <20080926185944.c2e7055a.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <48DCAB8C.5030405@linux.vnet.ibm.com> References: <20080925151124.25898d22.kamezawa.hiroyu@jp.fujitsu.com> <20080925151543.ba307898.kamezawa.hiroyu@jp.fujitsu.com> <48DCA01C.9020701@linux.vnet.ibm.com> <20080926182122.c7c88a65.kamezawa.hiroyu@jp.fujitsu.com> <48DCAB8C.5030405@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: balbir@linux.vnet.ibm.com Cc: "linux-mm@kvack.org" , "nishimura@mxp.nes.nec.co.jp" , "xemul@openvz.org" , Andrew Morton , LKML , Dave Hansen , ryov@valinux.co.jp List-ID: On Fri, 26 Sep 2008 14:59:48 +0530 Balbir Singh wrote: > > I think "feature" flag is complicated, at this stage. > > We'll add more features and not settled yet. > > > > I know.. but breaking ABI is a bad bad thing. We'll have to keep the feature > flags extensible (add new things). If we all feel we don't have enough users > affected by this change, I might agree with you and make that change. > Hmm...I'll drop this and add force_empty_may_fail logic in changes in force_empty. > > Hmm, if you don't like this, > > calling try_to_free_page() at force_empty() instead of move_account() ? > > > > Not sure I understand this. > In following series, force_empty() uses move_account() rather than forget all. By this, accounted file caches are kept as accounted and the whole accounting will be sane. Another choice is calling try_to_free_pages() at force_empty rather than forget all and makes memory usage to be Zero. This will also makes the whole accounting sange. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org