From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"xemul@openvz.org" <xemul@openvz.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Dave Hansen <haveblue@us.ibm.com>,
ryov@valinux.co.jp
Subject: [PATCH 1/12] memcg avoid accounting special mappings not on LRU
Date: Thu, 25 Sep 2008 15:13:07 +0900 [thread overview]
Message-ID: <20080925151307.f9cf352f.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20080925151124.25898d22.kamezawa.hiroyu@jp.fujitsu.com>
There are not-on-LRU pages which can be mapped and they are not worth to
be accounted. (becasue we can't shrink them and need dirty codes to handle
specical case) We'd like to make use of usual objrmap/radix-tree's protcol
and don't want to account out-of-vm's control pages.
When special_mapping_fault() is called, page->mapping is tend to be NULL
and it's charged as Anonymous page.
insert_page() also handles some special pages from drivers.
This patch is for avoiding to account special pages.
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
mm/memory.c | 18 ++++++------------
mm/rmap.c | 4 ++--
2 files changed, 8 insertions(+), 14 deletions(-)
Index: mmotm-2.6.27-rc6+/mm/memory.c
===================================================================
--- mmotm-2.6.27-rc6+.orig/mm/memory.c
+++ mmotm-2.6.27-rc6+/mm/memory.c
@@ -1323,18 +1323,14 @@ static int insert_page(struct vm_area_st
pte_t *pte;
spinlock_t *ptl;
- retval = mem_cgroup_charge(page, mm, GFP_KERNEL);
- if (retval)
- goto out;
-
retval = -EINVAL;
if (PageAnon(page))
- goto out_uncharge;
+ goto out;
retval = -ENOMEM;
flush_dcache_page(page);
pte = get_locked_pte(mm, addr, &ptl);
if (!pte)
- goto out_uncharge;
+ goto out;
retval = -EBUSY;
if (!pte_none(*pte))
goto out_unlock;
@@ -1350,8 +1346,6 @@ static int insert_page(struct vm_area_st
return retval;
out_unlock:
pte_unmap_unlock(pte, ptl);
-out_uncharge:
- mem_cgroup_uncharge_page(page);
out:
return retval;
}
@@ -2542,7 +2536,7 @@ static int __do_fault(struct mm_struct *
}
- if (mem_cgroup_charge(page, mm, GFP_KERNEL)) {
+ if (anon && mem_cgroup_charge(page, mm, GFP_KERNEL)) {
ret = VM_FAULT_OOM;
goto out;
}
@@ -2584,10 +2578,10 @@ static int __do_fault(struct mm_struct *
/* no need to invalidate: a not-present page won't be cached */
update_mmu_cache(vma, address, entry);
} else {
- mem_cgroup_uncharge_page(page);
- if (anon)
+ if (anon) {
+ mem_cgroup_uncharge_page(page);
page_cache_release(page);
- else
+ } else
anon = 1; /* no anon but release faulted_page */
}
Index: mmotm-2.6.27-rc6+/mm/rmap.c
===================================================================
--- mmotm-2.6.27-rc6+.orig/mm/rmap.c
+++ mmotm-2.6.27-rc6+/mm/rmap.c
@@ -725,8 +725,8 @@ void page_remove_rmap(struct page *page,
page_clear_dirty(page);
set_page_dirty(page);
}
-
- mem_cgroup_uncharge_page(page);
+ if (PageAnon(page))
+ mem_cgroup_uncharge_page(page);
__dec_zone_page_state(page,
PageAnon(page) ? NR_ANON_PAGES : NR_FILE_MAPPED);
/*
next prev parent reply other threads:[~2008-09-25 6:13 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 6:11 [PATCH 0/12] memcg updates v5 KAMEZAWA Hiroyuki
2008-09-25 6:13 ` KAMEZAWA Hiroyuki [this message]
2008-09-26 8:25 ` [PATCH 1/12] memcg avoid accounting special mappings not on LRU Balbir Singh
2008-09-26 9:17 ` KAMEZAWA Hiroyuki
2008-09-26 9:32 ` Balbir Singh
2008-09-26 9:55 ` KAMEZAWA Hiroyuki
2008-09-25 6:14 ` [PATCH 2/12] memcg move charege() call to swapped-in page under lock_page() KAMEZAWA Hiroyuki
2008-09-26 8:36 ` Balbir Singh
2008-09-26 9:18 ` KAMEZAWA Hiroyuki
2008-09-25 6:15 ` [PATCH 3/12] memcg make root cgroup unlimited KAMEZAWA Hiroyuki
2008-09-26 8:41 ` Balbir Singh
2008-09-26 9:21 ` KAMEZAWA Hiroyuki
2008-09-26 9:29 ` Balbir Singh
2008-09-26 9:59 ` KAMEZAWA Hiroyuki
2008-09-25 6:16 ` [PATCH 4/12] memcg make page->mapping NULL before calling uncharge KAMEZAWA Hiroyuki
2008-09-26 9:47 ` Balbir Singh
2008-09-26 10:07 ` KAMEZAWA Hiroyuki
2008-09-25 6:17 ` [PATCH 5/12] memcg make page_cgroup->flags atomic KAMEZAWA Hiroyuki
2008-09-27 6:58 ` Balbir Singh
2008-09-25 6:18 ` [PATCH 6/12] memcg optimize percpu stat KAMEZAWA Hiroyuki
2008-09-26 9:53 ` Balbir Singh
2008-09-25 6:27 ` [PATCH 7/12] memcg add function to move account KAMEZAWA Hiroyuki
2008-09-26 7:30 ` Daisuke Nishimura
2008-09-26 9:24 ` KAMEZAWA Hiroyuki
2008-09-27 7:56 ` Balbir Singh
2008-09-27 8:35 ` kamezawa.hiroyu
2008-09-25 6:29 ` [PATCH 8/12] memcg rewrite force empty to move account to root KAMEZAWA Hiroyuki
2008-09-25 6:32 ` [PATCH 9/12] memcg allocate all page_cgroup at boot KAMEZAWA Hiroyuki
2008-09-25 18:40 ` Dave Hansen
2008-09-26 1:17 ` KAMEZAWA Hiroyuki
2008-09-26 1:22 ` KAMEZAWA Hiroyuki
2008-09-26 1:00 ` Daisuke Nishimura
2008-09-26 1:43 ` KAMEZAWA Hiroyuki
2008-09-26 2:05 ` KAMEZAWA Hiroyuki
2008-09-26 5:54 ` Daisuke Nishimura
2008-09-26 6:54 ` KAMEZAWA Hiroyuki
2008-09-27 3:47 ` KAMEZAWA Hiroyuki
2008-09-27 3:25 ` KAMEZAWA Hiroyuki
2008-09-26 2:21 ` [PATCH(fixed) " KAMEZAWA Hiroyuki
2008-09-26 2:25 ` [PATCH(fixed) 10/12] free page cgroup from LRU in lazy KAMEZAWA Hiroyuki
2008-09-26 2:28 ` [PATCH(fixed) 11/12] free page cgroup from LRU in add KAMEZAWA Hiroyuki
2008-10-01 4:03 ` [PATCH 9/12] memcg allocate all page_cgroup at boot Balbir Singh
2008-10-01 5:07 ` KAMEZAWA Hiroyuki
2008-10-01 5:30 ` Balbir Singh
2008-10-01 5:41 ` KAMEZAWA Hiroyuki
2008-10-01 6:12 ` KAMEZAWA Hiroyuki
2008-10-01 6:26 ` Balbir Singh
2008-10-01 5:32 ` KAMEZAWA Hiroyuki
2008-10-01 5:59 ` Balbir Singh
2008-10-01 6:17 ` KAMEZAWA Hiroyuki
2008-09-25 6:33 ` [PATCH 10/12] memcg free page_cgroup from LRU in lazy KAMEZAWA Hiroyuki
2008-09-25 6:35 ` [PATCH 11/12] memcg add to " KAMEZAWA Hiroyuki
2008-09-25 6:36 ` [PATCH 12/12] memcg: fix race at charging swap-in KAMEZAWA Hiroyuki
2008-09-26 2:32 ` [PATCH 0/12] memcg updates v5 Daisuke Nishimura
2008-09-26 2:58 ` KAMEZAWA Hiroyuki
2008-09-26 3:04 ` KAMEZAWA Hiroyuki
2008-09-26 3:00 ` Daisuke Nishimura
2008-09-26 4:05 ` KAMEZAWA Hiroyuki
2008-09-26 5:24 ` Daisuke Nishimura
2008-09-26 9:28 ` KAMEZAWA Hiroyuki
2008-09-26 10:43 ` KAMEZAWA Hiroyuki
2008-09-27 2:53 ` KAMEZAWA Hiroyuki
2008-09-26 8:18 ` Balbir Singh
2008-09-26 9:22 ` KAMEZAWA Hiroyuki
2008-09-26 9:31 ` Balbir Singh
2008-09-26 10:36 ` KAMEZAWA Hiroyuki
2008-09-27 3:19 ` KAMEZAWA Hiroyuki
2008-09-29 3:02 ` Balbir Singh
2008-09-29 3:27 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925151307.f9cf352f.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=ryov@valinux.co.jp \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox