From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Salman Qazi <sqazi@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: mlock: Make the mlock system call interruptible by fatal
Date: Wed, 24 Sep 2008 09:20:40 -0700 [thread overview]
Message-ID: <20080924092040.d8407311.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080924112255.64304a64@lxorguk.ukuu.org.uk>
On Wed, 24 Sep 2008 11:22:55 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > > Can we do
> > >
> > > return i ? i : -EINTR;
> > >
> > > in the usual fashion?
> >
> > Fixed.
>
> If its only interruptible by fatal signals why do we care what the return
> is ?
>
For the immediate in-kernel caller. __get_user_pages() took a ref on a
few pages which the caller needs to undo before doing anything else
(like processing the signal).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-09-24 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 22:47 Salman Qazi
2008-09-24 10:22 ` Alan Cox
2008-09-24 11:49 ` Oliver Neukum
2008-09-24 16:20 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080924092040.d8407311.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sqazi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox