Re: [PATCH -mm] memcg: fix handling of shmem migration

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Wed, 17 Sep 2008 15:19:51 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:

> Hmm, something like this?
> 
> ---
> @@ -734,6 +734,9 @@ int mem_cgroup_prepare_migration(struct page *page, struct page *newpa
>         if (mem_cgroup_subsys.disabled)
>                 return 0;
> 
> +       if (PageSwapBacked(page))
> +               SetPageSwapBacked(newpage);
> +
>         lock_page_cgroup(page);
>         pc = page_get_page_cgroup(page);
>         if (pc) {
> ---
> 
> Or, adding MEM_CGROUP_CHARGE_TYPE_SHMEM and
> 
> ---
> @@ -740,7 +740,10 @@ int mem_cgroup_prepare_migration(struct page *page, struct page *newp
>                 mem = pc->mem_cgroup;
>                 css_get(&mem->css);
>                 if (pc->flags & PAGE_CGROUP_FLAG_CACHE)
> -                       ctype = MEM_CGROUP_CHARGE_TYPE_CACHE;
> +                       if (page_is_file_cache(page))
> +                               ctype = MEM_CGROUP_CHARGE_TYPE_CACHE;
> +                       else
> +                               ctype = MEM_CGROUP_CHARGE_TYPE_SHMEM;
>         }
>         unlock_page_cgroup(page);
>         if (mem) {
> ---
> (Of course, mem_cgroup_charge_common should be modified too.)
> 
like this :) I don't want to change logic in migration.c
(and this is special case handling for memcg.)

Thanks,
-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>