From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, balbir@linux.vnet.ibm.com,
xemul@openvz.org
Subject: Re: [PATCH -mm] memcg: fix handling of shmem migration
Date: Wed, 17 Sep 2008 14:50:03 +0900 [thread overview]
Message-ID: <20080917145003.fb4d0b95.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20080917144659.2e363edc.kamezawa.hiroyu@jp.fujitsu.com>
On Wed, 17 Sep 2008 14:46:59 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Wed, 17 Sep 2008 13:31:49 +0900
> Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
>
> > PG_swapbacked flag of newpage should be set(if needed) before
> > mem_cgroup_prepare_migration, because mem_cgroup_charge_common
> > checks the flag and determines whether it sets PAGE_CGROUP_FLAG_FILE or not.
> >
> > Before this patch, if migrating shmem/tmpfs pages, newpage would be
> > charged with PAGE_CGROUP_FLAG_FILE set, while oldpage has been charged
> > without the flag.
> >
> Nice catch !
> Thank you.
>
> Hmm, should I add MEM_CGROUP_CHARGE_TYPE_SHMEM rather than
> setting flag to newpage ?
>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
I acked but.. can't this change moved into memcontrol.c ?
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-09-17 5:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 4:31 Daisuke Nishimura
2008-09-17 5:46 ` KAMEZAWA Hiroyuki
2008-09-17 5:50 ` KAMEZAWA Hiroyuki [this message]
2008-09-17 6:19 ` Daisuke Nishimura
2008-09-17 6:38 ` KAMEZAWA Hiroyuki
2008-09-17 6:45 ` Daisuke Nishimura
2008-09-17 7:55 ` [PATCH -mm] memcg: fix handling of shmem migration(v2) Daisuke Nishimura
2008-09-17 9:18 ` KAMEZAWA Hiroyuki
2008-09-17 22:51 ` Andrew Morton
2008-09-18 2:03 ` Daisuke Nishimura
2008-09-18 2:38 ` KAMEZAWA Hiroyuki
2008-09-18 5:43 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080917145003.fb4d0b95.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox