From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 12 Sep 2008 13:36:01 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC] [PATCH 3/9] memcg: move_account between groups Message-Id: <20080912133601.1d3d82a6.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20080911201451.6aecd29a.kamezawa.hiroyu@jp.fujitsu.com> References: <20080911200855.94d33d3b.kamezawa.hiroyu@jp.fujitsu.com> <20080911201451.6aecd29a.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: balbir@linux.vnet.ibm.com, "xemul@openvz.org" , "hugh@veritas.com" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, menage@google.com List-ID: On Thu, 11 Sep 2008 20:14:51 +0900 KAMEZAWA Hiroyuki wrote: > + if (try_lock_page_cgroup(page)) > + return ret; Here is buggy and should be !try_lock_page_cgroup(). and uncharge should be called. > + > + if (page_get_page_cgroup(page) != pc) > + goto out; uncharge should be called. Updated version will appear in the next week. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org