From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Badari Pulavarty <pbadari@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel ML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC:Patch: 008/008](memory hotplug) remove_pgdat() function
Date: Mon, 08 Sep 2008 12:07:14 +0900 [thread overview]
Message-ID: <20080908120324.B3DA.E1E9C6FF@jp.fujitsu.com> (raw)
In-Reply-To: <1220710895.8687.12.camel@twins.programming.kicks-ass.net>
> On Thu, 2008-07-31 at 21:04 +0900, Yasunori Goto wrote:
>
> > +int remove_pgdat(int nid)
> > +{
> > + struct pglist_data *pgdat = NODE_DATA(nid);
> > +
> > + if (cpus_busy_on_node(nid))
> > + return -EBUSY;
> > +
> > + if (sections_busy_on_node(pgdat))
> > + return -EBUSY;
> > +
> > + node_set_offline(nid);
> > + synchronize_sched();
> > + synchronize_srcu(&pgdat_remove_srcu);
> > +
> > + free_pgdat(nid, pgdat);
> > +
> > + return 0;
> > +}
>
> FWIW synchronize_sched() is the wrong function to use here,
> synchronize_rcu() is the right one.
Thanks. I'll fix it.
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-09-08 3:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 11:50 [RFC:Patch: 000/008](memory hotplug) rough idea of pgdat removing Yasunori Goto
2008-07-31 11:55 ` [RFC:Patch: 001/008](memory hotplug) change parameter from pointer of zonelist to node id Yasunori Goto
2008-07-31 11:56 ` [RFC:Patch: 002/008](memory hotplug) pgdat_remove_read_lock/unlock Yasunori Goto
2008-07-31 11:58 ` [RFC:Patch: 003/008](memory hotplug) check node online in __alloc_pages Yasunori Goto
2008-07-31 12:00 ` [RFC:Patch: 004/008](memory hotplug) Use lock for for_each_online_node Yasunori Goto
2008-07-31 12:01 ` [RFC:Patch: 005/008](memory hotplug) check node online before NODE_DATA and so on Yasunori Goto
2008-07-31 12:02 ` [RFC:Patch: 006/008](memory hotplug) kswapd_stop() definition Yasunori Goto
2008-07-31 12:03 ` [RFC:Patch: 007/008](memory hotplug) callback routine for mempolicy Yasunori Goto
2008-07-31 12:04 ` [RFC:Patch: 008/008](memory hotplug) remove_pgdat() function Yasunori Goto
2008-09-06 14:21 ` Peter Zijlstra
2008-09-08 3:07 ` Yasunori Goto [this message]
2008-07-31 14:04 ` [RFC:Patch: 000/008](memory hotplug) rough idea of pgdat removing Christoph Lameter
2008-08-01 9:42 ` Yasunori Goto
2008-08-01 13:51 ` Christoph Lameter
2008-08-02 0:16 ` Yasunori Goto
2008-08-04 13:25 ` Christoph Lameter
2008-08-05 6:39 ` Yasunori Goto
2008-08-05 11:14 ` Mel Gorman
2008-08-05 17:08 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080908120324.B3DA.E1E9C6FF@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=pbadari@us.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox