From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 4 Sep 2008 20:06:25 -0700 From: Andrew Morton Subject: Re: [patch] mm: rewrite vmap layer Message-Id: <20080904200625.a926e274.akpm@linux-foundation.org> In-Reply-To: <20080818133224.GA5258@wotan.suse.de> References: <20080818133224.GA5258@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Linux Memory Management List , linux-arch@vger.kernel.org, Dave Airlie List-ID: On Mon, 18 Aug 2008 15:32:24 +0200 Nick Piggin wrote: > Rewrite the vmap allocator to use rbtrees and lazy tlb flushing, and provide a > fast, scalable percpu frontend for small vmaps (requires a slightly different > API, though). With the full -mm lineup my ancient PIII machine is saying calling agp_init+0x0/0x30 Linux agpgart interface v0.103 initcall agp_init+0x0/0x30 returned 0 after 0 msecs calling agp_intel_init+0x0/0x30 agpgart-intel 0000:00:00.0: Intel 440BX Chipset ------------[ cut here ]------------ WARNING: at mm/vmalloc.c:105 vmap_page_range+0xea/0x130() Modules linked in: Pid: 1, comm: swapper Not tainted 2.6.27-rc5-mm1 #1 [] warn_on_slowpath+0x54/0x70 [] ? rmqueue_bulk+0x69/0x80 [] ? trace_hardirqs_on+0xb/0x10 [] ? trace_hardirqs_on_caller+0xd4/0x160 [] ? get_page_from_freelist+0x229/0x4f0 [] vmap_page_range+0xea/0x130 [] map_vm_area+0x31/0x50 [] __vmalloc_area_node+0xb4/0x110 [] __vmalloc_node+0x99/0xa0 [] ? agp_add_bridge+0x1e0/0x4b0 [] ? agp_add_bridge+0x1e0/0x4b0 [] vmalloc+0x23/0x30 [] ? agp_add_bridge+0x1e0/0x4b0 [] agp_add_bridge+0x1e0/0x4b0 [] agp_intel_probe+0x145/0x2d0 [] pci_device_probe+0x5e/0x80 [] driver_probe_device+0x84/0x180 [] __driver_attach+0x75/0x80 [] bus_for_each_dev+0x49/0x70 [] ? pci_device_remove+0x0/0x40 [] driver_attach+0x19/0x20 [] ? __driver_attach+0x0/0x80 [] bus_add_driver+0xaf/0x220 [] ? kset_find_obj+0x5f/0x80 [] ? pci_device_remove+0x0/0x40 [] driver_register+0x4f/0x120 [] ? __spin_lock_init+0x32/0x60 [] ? agp_intel_init+0x0/0x30 [] __pci_register_driver+0x5b/0xb0 [] ? agp_intel_init+0x0/0x30 [] agp_intel_init+0x25/0x30 [] _stext+0x2a/0x150 [] ? agp_intel_init+0x0/0x30 [] ? wake_up_process+0xf/0x20 [] ? start_workqueue_thread+0x1d/0x20 [] ? __create_workqueue_key+0x143/0x190 [] kernel_init+0x182/0x280 [] ? kernel_init+0x0/0x280 [] kernel_thread_helper+0x7/0x18 ======================= ---[ end trace e9106f0cfec79452 ]--- agpgart-intel 0000:00:00.0: can't allocate memory for key lists agpgart-intel 0000:00:00.0: agp_backend_initialize() failed agpgart-intel: probe of 0000:00:00.0 failed with error -12 initcall agp_intel_init+0x0/0x30 returned 0 after 10 msecs : static int vmap_pte_range(pmd_t *pmd, unsigned long addr, : unsigned long end, pgprot_t prot, struct page **pages, int *nr) : { : pte_t *pte; : : /* : * nr is a running index into the array which helps higher level : * callers keep track of where we're up to. : */ : : pte = pte_alloc_kernel(pmd, addr); : if (!pte) : return -ENOMEM; : do { : struct page *page = pages[*nr]; : : -->> if (WARN_ON(!pte_none(*pte))) : return -EBUSY; : if (WARN_ON(!page)) : return -ENOMEM; : set_pte_at(&init_mm, addr, pte, mk_pte(page, prot)); : (*nr)++; : } while (pte++, addr += PAGE_SIZE, addr != end); : return 0; : } : wanna take a look please? config: http://userweb.kernel.org/~akpm/config-vmm.txt dmesg: http://userweb.kernel.org/~akpm/dmesg-vmm.txt -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org