From: Lee Schermerhorn <lee.schermerhorn@hp.com>
To: akpm@linux-foundation.org
Cc: riel@redhat.com, linux-mm <linux-mm@kvack.org>,
kosaki.motohiro@jp.fujitsu.com, Eric.Whitney@hp.com
Subject: [PATCH 6/7] Mlock: revert mainline handling of mlock error return
Date: Fri, 22 Aug 2008 17:11:06 -0400 [thread overview]
Message-ID: <20080822211106.29898.37903.sendpatchset@murky.usa.hp.com> (raw)
In-Reply-To: <20080822211028.29898.82599.sendpatchset@murky.usa.hp.com>
Revert the change to make_page_present() error return.
This change is intended to make mlock() error returns correct.
make_page_present() is a lower level function used by more than
mlock(). Subsequent patch[es] will add this error return fixup
in an mlock specific path.
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
mm/memory.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
Index: linux-2.6.27-rc3-mmotm/mm/memory.c
===================================================================
--- linux-2.6.27-rc3-mmotm.orig/mm/memory.c 2008-08-18 14:50:36.000000000 -0400
+++ linux-2.6.27-rc3-mmotm/mm/memory.c 2008-08-18 14:53:15.000000000 -0400
@@ -2819,19 +2819,9 @@ int make_pages_present(unsigned long add
len = DIV_ROUND_UP(end, PAGE_SIZE) - addr/PAGE_SIZE;
ret = get_user_pages(current, current->mm, addr,
len, write, 0, NULL, NULL);
- if (ret < 0) {
- /*
- SUS require strange return value to mlock
- - invalid addr generate to ENOMEM.
- - out of memory should generate EAGAIN.
- */
- if (ret == -EFAULT)
- ret = -ENOMEM;
- else if (ret == -ENOMEM)
- ret = -EAGAIN;
+ if (ret < 0)
return ret;
- }
- return ret == len ? 0 : -ENOMEM;
+ return ret == len ? 0 : -1;
}
#if !defined(__HAVE_ARCH_GATE_AREA)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-08-22 21:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 21:10 [Patch 0/7] Mlock: doc, patch grouping and error return cleanups Lee Schermerhorn
2008-08-22 21:10 ` [PATCH 1/7] Mlock: fix __mlock_vma_pages_range comment block Lee Schermerhorn
2008-08-22 21:10 ` [PATCH 2/7] Mlock: backout locked_vm adjustment during mmap() Lee Schermerhorn
2008-08-22 21:10 ` [PATCH 3/7] Mlock: resubmit locked_vm adjustment as separate patch Lee Schermerhorn
2008-08-22 23:11 ` Andrew Morton
2008-08-25 13:01 ` Lee Schermerhorn
2008-08-22 21:10 ` [PATCH 4/7] Mlock: fix return value for munmap/mlock vma race Lee Schermerhorn
2008-08-22 21:11 ` [PATCH 5/7] Mlock: update locked_vm on munmap() of mlocked() region Lee Schermerhorn
2008-08-22 21:11 ` Lee Schermerhorn [this message]
2008-08-22 21:11 ` [PATCH 7/7] Mlock: make mlock error return Posixly Correct Lee Schermerhorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080822211106.29898.37903.sendpatchset@murky.usa.hp.com \
--to=lee.schermerhorn@hp.com \
--cc=Eric.Whitney@hp.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox