linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: penberg@cs.helsinki.fi, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, rdunlap@xenotime.net, mpm@selenic.com,
	tglx@linutronix.de, rostedt@goodmis.org,
	mathieu.desnoyers@polymtl.ca, tzanussi@gmail.com
Subject: Re: [PATCH 3/5] SLUB: Replace __builtin_return_address(0) with _RET_IP_.
Date: Tue, 19 Aug 2008 22:05:06 +0300	[thread overview]
Message-ID: <20080819190506.GC5520@localhost> (raw)
In-Reply-To: <48AB1769.3040703@linux-foundation.org>

On Tue, Aug 19, 2008 at 01:56:41PM -0500, Christoph Lameter wrote:

> Well maybe this patch will do it then:
> 
> Subject: slub: Use _RET_IP and use "unsigned long" for kernel text addresses
> 
> Use _RET_IP_ instead of buildint_return_address() and make slub use unsigned long
> instead of void * for addresses.
> 
> Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
> 
> ---
>  mm/slub.c |   46 +++++++++++++++++++++++-----------------------
>  1 file changed, 23 insertions(+), 23 deletions(-)

It seems Pekka just submitted something like this. Though I think using 0L
should be replaced with 0UL to be fully correct.

Pekka, should I test one of these variants and resubmit, or will you
merge it by yourself?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-08-19 19:08 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-19 17:43 [PATCH 1/5] Revert "kmemtrace: fix printk format warnings" Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 2/5] kmemtrace: Better alternative to " Eduard - Gabriel Munteanu
2008-08-19 17:43   ` [PATCH 3/5] SLUB: Replace __builtin_return_address(0) with _RET_IP_ Eduard - Gabriel Munteanu
2008-08-19 17:43     ` [PATCH 4/5] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-08-19 17:43       ` [PATCH 5/5] kmemtrace: Fix 2 typos in documentation Eduard - Gabriel Munteanu
2008-08-19 19:10         ` Pekka Enberg
2008-08-19 19:10       ` [PATCH 4/5] kmemtrace: SLUB hooks Pekka Enberg
2008-08-19 18:14     ` [PATCH 3/5] SLUB: Replace __builtin_return_address(0) with _RET_IP_ Christoph Lameter
2008-08-19 18:24       ` Eduard - Gabriel Munteanu
2008-08-19 18:56         ` Christoph Lameter
2008-08-19 18:59           ` Pekka Enberg
2008-08-19 19:05           ` Eduard - Gabriel Munteanu [this message]
2008-08-19 19:09             ` Pekka Enberg
2008-08-19 19:09           ` Pekka Enberg
2008-08-19 20:17             ` Christoph Lameter
2008-08-19 20:16               ` Pekka Enberg
2008-08-19 20:23                 ` Christoph Lameter
2008-08-19 20:47                   ` Pekka Enberg
2008-08-19 18:50       ` Pekka J Enberg
2008-08-19 19:24   ` [PATCH 2/5] kmemtrace: Better alternative to "kmemtrace: fix printk format warnings" Pekka Enberg
2008-08-19 17:51 ` [PATCH 1/5] Revert " Randy.Dunlap
2008-08-19 17:54   ` Eduard - Gabriel Munteanu
2008-08-19 18:16     ` Mathieu Desnoyers
2008-08-19 18:32       ` Eduard - Gabriel Munteanu
2008-08-19 19:25         ` Pekka Enberg
2008-08-19 20:23           ` Mathieu Desnoyers
2008-08-19 18:47       ` Frank Ch. Eigler
2008-08-19 19:32     ` Randy.Dunlap
2008-08-19 21:37       ` Eduard - Gabriel Munteanu
2008-08-19 19:27 ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080819190506.GC5520@localhost \
    --to=eduard.munteanu@linux360.ro \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mpm@selenic.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=rdunlap@xenotime.net \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox