From: yamamoto@valinux.co.jp (YAMAMOTO Takashi)
To: a.p.zijlstra@chello.nl
Cc: kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org,
menage@google.com, containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] dirty balancing for cgroups
Date: Wed, 13 Aug 2008 16:15:05 +0900 (JST) [thread overview]
Message-ID: <20080813071505.930965A75@siro.lan> (raw)
In-Reply-To: Your message of "Thu, 07 Aug 2008 15:36:08 +0200" <1218116168.8625.38.camel@twins>
hi,
> > @@ -485,7 +502,10 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan,
> > if (PageUnevictable(page) ||
> > (PageActive(page) && !active) ||
> > (!PageActive(page) && active)) {
> > - __mem_cgroup_move_lists(pc, page_lru(page));
> > + if (try_lock_page_cgroup(page)) {
> > + __mem_cgroup_move_lists(pc, page_lru(page));
> > + unlock_page_cgroup(page);
> > + }
> > continue;
> > }
>
> This chunk seems unrelated and lost....
it's necessary to protect from mem_cgroup_{set,clear}_dirty
which modify pc->flags without holding mz->lru_lock.
> I presonally dislike the != 0, == 0 comparisons for bitmask operations,
> they seem to make it harder to read somewhow. I prefer to write !(flags
> & mask) and (flags & mask), instead.
>
> I guess taste differs,...
yes, it seems different. :)
YAMAMOTO Takashi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-08-13 7:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080711085449.ba7d14dd.kamezawa.hiroyu@jp.fujitsu.com>
2008-07-11 4:06 ` YAMAMOTO Takashi
2008-07-11 5:15 ` KAMEZAWA Hiroyuki
2008-07-11 5:59 ` YAMAMOTO Takashi
2008-07-11 7:13 ` KAMEZAWA Hiroyuki
2008-07-11 8:34 ` YAMAMOTO Takashi
2008-07-11 8:52 ` KAMEZAWA Hiroyuki
2008-08-06 8:20 ` YAMAMOTO Takashi
2008-08-06 8:53 ` KAMEZAWA Hiroyuki
2008-08-06 9:10 ` YAMAMOTO Takashi
2008-08-07 13:36 ` Peter Zijlstra
2008-08-13 7:15 ` YAMAMOTO Takashi [this message]
2008-08-18 7:58 ` KAMEZAWA Hiroyuki
2008-07-14 13:49 ` Peter Zijlstra
2008-07-17 1:43 ` YAMAMOTO Takashi
2008-08-14 8:38 ` Paul Menage
2008-07-14 14:38 ` kamezawa.hiroyu
[not found] <20080709060034.0CB2D5A29@siro.lan>
2008-07-14 13:37 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080813071505.930965A75@siro.lan \
--to=yamamoto@valinux.co.jp \
--cc=a.p.zijlstra@chello.nl \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox