From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Rik van Riel <riel@redhat.com>
Cc: kosaki.motohiro@jp.fujitsu.com
Subject: [RFC PATCH for -mm 2/5] related function comment fixes (optional)
Date: Mon, 11 Aug 2008 16:05:37 +0900 [thread overview]
Message-ID: <20080811160430.945C.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20080811151313.9456.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Now, __mlock_vma_pages_range has sevaral wrong comment.
- don't write about mlock parameter
- write about require write lock, but it is not true.
following patch fixes it.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/mlock.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
Index: b/mm/mlock.c
===================================================================
--- a/mm/mlock.c
+++ b/mm/mlock.c
@@ -144,11 +144,18 @@ static void munlock_vma_page(struct page
}
/*
- * mlock a range of pages in the vma.
+ * mlock/munlock a range of pages in the vma.
*
- * This takes care of making the pages present too.
+ * If @mlock==1, this takes care of making the pages present too.
*
- * vma->vm_mm->mmap_sem must be held for write.
+ * @vma: target vma
+ * @start: start address
+ * @end: end address
+ * @mlock: 0 indicate munlock, otherwise mlock.
+ *
+ * return 0 if successed, otherwse return negative value.
+ *
+ * vma->vm_mm->mmap_sem must be held for read.
*/
static int __mlock_vma_pages_range(struct vm_area_struct *vma,
unsigned long start, unsigned long end,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-08-11 7:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 7:01 [RFC PATCH for -mm 0/5] mlock return value rework KOSAKI Motohiro
2008-08-11 7:04 ` [RFC PATCH for -mm 1/5] mlock() fix return values for mainline KOSAKI Motohiro
2008-08-12 20:39 ` Lee Schermerhorn
2008-08-13 8:03 ` KOSAKI Motohiro
2008-08-11 7:05 ` KOSAKI Motohiro [this message]
2008-08-12 19:02 ` [RFC PATCH for -mm 2/5] related function comment fixes (optional) Lee Schermerhorn
2008-08-13 8:37 ` KOSAKI Motohiro
2008-08-11 7:06 ` [RFC PATCH for -mm 3/5] kill unnecessary locked_vm adjustment KOSAKI Motohiro
2008-08-12 19:55 ` Lee Schermerhorn
2008-08-13 9:37 ` KOSAKI Motohiro
2008-08-15 13:54 ` Lee Schermerhorn
2008-08-18 9:23 ` KOSAKI Motohiro
2008-08-18 20:56 ` Lee Schermerhorn
2008-08-11 7:07 ` [RFC PATCH for -mm 4/5] fix mlock return value at munmap race KOSAKI Motohiro
2008-08-12 20:19 ` Lee Schermerhorn
2008-08-11 7:08 ` [RFC PATCH for -mm 5/5] fix mlock return value for mm KOSAKI Motohiro
2008-08-11 7:43 ` KOSAKI Motohiro
2008-08-12 20:30 ` Lee Schermerhorn
2008-08-13 8:36 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080811160430.945C.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox