From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 31 Jul 2008 21:02:21 +0900 From: Yasunori Goto Subject: [RFC:Patch: 006/008](memory hotplug) kswapd_stop() definition In-Reply-To: <20080731203549.2A3F.E1E9C6FF@jp.fujitsu.com> References: <20080731203549.2A3F.E1E9C6FF@jp.fujitsu.com> Message-Id: <20080731210119.2A4D.E1E9C6FF@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Badari Pulavarty Cc: Andrew Morton , Mel Gorman , Christoph Lameter , linux-mm , Linux Kernel ML List-ID: This patch is to make kswapd_stop(). It must be stopped before node removing. Signed-off-by: Yasunori Goto --- include/linux/swap.h | 3 +++ mm/vmscan.c | 13 +++++++++++++ 2 files changed, 16 insertions(+) Index: current/mm/vmscan.c =================================================================== --- current.orig/mm/vmscan.c 2008-07-29 22:17:16.000000000 +0900 +++ current/mm/vmscan.c 2008-07-29 22:17:16.000000000 +0900 @@ -1985,6 +1985,9 @@ static int kswapd(void *p) } finish_wait(&pgdat->kswapd_wait, &wait); + if (kthread_should_stop()) + break; + if (!try_to_freeze()) { /* We can speed up thawing tasks if we don't call * balance_pgdat after returning from the refrigerator @@ -2216,6 +2219,16 @@ int kswapd_run(int nid) return ret; } +#ifdef CONFIG_MEMORY_HOTREMOVE +void kswapd_stop(int nid) +{ + pg_data_t *pgdat = NODE_DATA(nid); + + if (pgdat->kswapd) + kthread_stop(pgdat->kswapd); +} +#endif + static int __init kswapd_init(void) { int nid; Index: current/include/linux/swap.h =================================================================== --- current.orig/include/linux/swap.h 2008-07-29 21:20:02.000000000 +0900 +++ current/include/linux/swap.h 2008-07-29 22:17:16.000000000 +0900 @@ -262,6 +262,9 @@ static inline void scan_unevictable_unre #endif extern int kswapd_run(int nid); +#ifdef CONFIG_MEMORY_HOTREMOVE +extern void kswapd_stop(int nid); +#endif #ifdef CONFIG_MMU /* linux/mm/shmem.c */ -- Yasunori Goto -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org