linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: PERF: performance tests with the split LRU VM in -mm
Date: Mon, 28 Jul 2008 16:41:24 -0700	[thread overview]
Message-ID: <20080728164124.8240eabe.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080728105742.50d6514e@cuia.bos.redhat.com>

On Mon, 28 Jul 2008 10:57:42 -0400
Rik van Riel <riel@redhat.com> wrote:

> On Thu, 24 Jul 2008 22:25:10 -0400
> Rik van Riel <riel@redhat.com> wrote:
> 
> >   TEST 1: dd if=/dev/sda of=/dev/null bs=1M
> > 
> > kernel  speed    swap used
> > 
> > 2.6.26  111MB/s  500kB
> > -mm     110MB/s  59MB     (ouch, system noticably slower)
> > noforce	111MB/s  128kB
> > stream  108MB/s  0        (slight regression, not sure why yet)
> > 
> > This patch shows that the split LRU VM in -mm has a problem
> > with large streaming IOs: the working set gets pushed out of
> > memory, which makes doing anything else during the big streaming
> > IO kind of painful.
> > 
> > However, either of the two patches posted fixes that problem,
> > though at a slight performance penalty for the "stream" patch.
> 
> OK, the throughput number with this test turns out not to mean
> nearly as much as I thought.
> 
> Switching off CPU frequency scaling, pinning the CPUs at the
> highest speed, resulted in a throughput of only 102MB/s.
> 
> My suspicion is that faster running code on the CPU results
> in IOs being sent down to the device faster, resulting in
> smaller IOs and lower throughput.
> 
> This would be promising for the "stream" patch, which makes
> choosing between the two patches harder :)
> 
> Andrew, what is your preference between:
> 	http://lkml.org/lkml/2008/7/15/465
> and
> 	http://marc.info/?l=linux-mm&m=121683855132630&w=2
> 

Boy.  They both seem rather hacky special-cases.  But that doesn't mean
that they're undesirable hacky special-cases.  I guess the second one
looks a bit more "algorithmic" and a bit less hacky-special-case.  But
it all depends on testing..

On a different topic, these:

vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch
vm-dont-run-touch_buffer-during-buffercache-lookups.patch

have been floating about in -mm for ages, awaiting demonstration that
they're a net benefit.  But all of this new page-reclaim rework was
built on top of those two patches and incorporates and retains them.

I could toss them out, but that would require some rework and would
partially invalidate previous testing and who knows, they _might_ be
good patches.  Or they might not be.

What are your thoughts?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-07-28 23:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25  2:25 Rik van Riel
2008-07-28 14:57 ` Rik van Riel
2008-07-28 15:30   ` Ray Lee
2008-07-28 23:41   ` Andrew Morton [this message]
2008-07-28 23:57     ` Rik van Riel
2008-07-29  0:03       ` Rik van Riel
2008-07-29  0:17         ` Andrew Morton
2008-07-29  0:31           ` Rik van Riel
2008-07-29  0:46           ` Lee Schermerhorn
2008-07-29 13:21         ` Johannes Weiner
2008-07-29 13:28           ` Rik van Riel
2008-07-29 13:04 ` KOSAKI Motohiro
2008-07-29 13:16   ` Rik van Riel
2008-07-29 13:51 ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080728164124.8240eabe.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox