linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jack Steiner <steiner@sgi.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-arch@vger.kernel.org, andrea@qumranet.com,
	cl@linux-foundation.org
Subject: Re: MMU notifiers review and some proposals
Date: Fri, 25 Jul 2008 18:29:09 -0500	[thread overview]
Message-ID: <20080725232907.GA243187@sgi.com> (raw)
In-Reply-To: <20080724143949.GB12897@wotan.suse.de>

> 
> I also think we should be cautious to make this slowpath so horribly
> slow. For KVM it's fine, but perhaps for GRU we'd actually want to
> register quite a lot of notifiers, unregister them, and perhaps even
> do per-vma registrations if we don't want to slow down other memory
> management operations too much (eg. if it is otherwise just some
> regular processes just doing accelerated things with GRU).

I can't speak for other possible users of the mmu notifier mechanism
but the GRU will only register a single notifier for a process.
The notifier is registered when the GRU is opened and (currently)
unregistered when the GRU is closed.

If a task opens multiple GRUs (quite possible for threaded apps), all
shared the same notifier. Regardless of the number of threads/opens,
there will be a single notifier. 


At least one version of mmu notifiers did not support unregistration.
The notifier was left in the chain until the task exited. This
also worked for the GRU. If the gru was subsequently reopened
the notifier was reused. Providing the ability to unregister is the
right thing to do if the cost is not excessive. From a practical
standpoint, for the GRU usage, unregistration is not a big issue
either way.

--- jack

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-07-25 23:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 14:39 Nick Piggin
2008-07-25 21:45 ` Andrea Arcangeli
2008-07-26  3:08   ` Nick Piggin
2008-07-26 11:38     ` Andrea Arcangeli
2008-07-26 12:28       ` Nick Piggin
2008-07-26 13:02         ` Andrea Arcangeli
2008-07-26 13:10           ` Nick Piggin
2008-07-26 13:35             ` Andrea Arcangeli
2008-07-27 12:25               ` Nick Piggin
2008-07-26 13:14           ` Nick Piggin
2008-07-26 13:49             ` Andrea Arcangeli
2008-07-27 12:32               ` Nick Piggin
2008-07-30 14:19             ` Christoph Lameter
2008-07-30 14:54               ` Andrea Arcangeli
2008-07-30 15:42                 ` Christoph Lameter
2008-07-31  6:14                   ` Nick Piggin
2008-07-31 14:19                     ` Christoph Lameter
2008-07-26 12:33       ` Nick Piggin
2008-07-26 13:04       ` Nick Piggin
2008-07-26 13:16         ` Andrea Arcangeli
2008-07-27 12:08           ` Nick Piggin
2008-07-25 23:29 ` Jack Steiner [this message]
2008-07-26  3:18   ` Nick Piggin
2008-07-27  9:45 ` Andrew Morton
2008-07-27 12:38   ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080725232907.GA243187@sgi.com \
    --to=steiner@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrea@qumranet.com \
    --cc=cl@linux-foundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox