From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 25 Jul 2008 19:46:59 +0900 From: KOSAKI Motohiro Subject: Re: [PATCH 30/30] nfs: fix various memory recursions possible with swap over NFS. In-Reply-To: <20080724141531.486682621@chello.nl> References: <20080724140042.408642539@chello.nl> <20080724141531.486682621@chello.nl> Message-Id: <20080725194517.86BB.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Peter Zijlstra Cc: kosaki.motohiro@jp.fujitsu.com, Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, trond.myklebust@fys.uio.no, Daniel Lezcano , Pekka Enberg , Neil Brown List-ID: > GFP_NOFS is not enough, since swap traffic is IO, hence fall back to GFP_NOIO. this comment imply turn on GFP_NOIO, but the code is s/NOFS/NOIO/. why? > struct nfs_write_data *nfs_commitdata_alloc(void) > { > - struct nfs_write_data *p = kmem_cache_alloc(nfs_wdata_cachep, GFP_NOFS); > + struct nfs_write_data *p = kmem_cache_alloc(nfs_wdata_cachep, GFP_NOIO); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org