Re: [mmotm][PATCH 5/9] mlock-mlocked-pages-are-unevictable.patch

[KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>]

> > > unevictable-lru-infrastructure-putback_lru_page-rework.patch and unevictable-lru-infrastructure-kill-unnecessary-lock_page.patch
> > > makes following patch failure.
> > 
> > This patch (or one nearby) breaks nommu:
> > 
> > mm/built-in.o(.text+0x1bb70): In function `truncate_complete_page':
> > : undefined reference to `__clear_page_mlock'
> > mm/built-in.o(.text+0x1ca90): In function `__invalidate_mapping_pages':
> > : undefined reference to `__clear_page_mlock'
> > mm/built-in.o(.text+0x1d29c): In function `invalidate_inode_pages2_range':
> > : undefined reference to `__clear_page_mlock'
> 
> sorry, I have very limited code viewing environment on this week because OLS.
> Lee-san, Could you review code today?
> 
> I guess __clear_page_mlock() written in wrong ifdef..


Andrew, maybe following patch fixes build error.
Please apply.

------------------------------------
Against:       mmotm Jul 23
Applies after: revert-to-unevictable-lru-infrastructure-kconfig-fixpatch.patch

Current unevictable infrastructure code depend on MMU.
Then, nommu build cause following error.

mm/built-in.o(.text+0x1bb70): In function `truncate_complete_page':
: undefined reference to `__clear_page_mlock'
mm/built-in.o(.text+0x1ca90): In function `__invalidate_mapping_pages':
: undefined reference to `__clear_page_mlock'
mm/built-in.o(.text+0x1d29c): In function `invalidate_inode_pages2_range':
: undefined reference to `__clear_page_mlock'


So, adding dependency to Kconfig is better.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

Index: linux-2.6.26-mmotm-0723/mm/Kconfig
===================================================================
--- linux-2.6.26-mmotm-0723.orig/mm/Kconfig	2008-07-25 11:47:13.000000000 +0900
+++ linux-2.6.26-mmotm-0723/mm/Kconfig	2008-07-25 11:51:36.000000000 +0900
@@ -212,6 +212,7 @@
 config UNEVICTABLE_LRU
 	bool "Add LRU list to track non-evictable pages"
 	default y
+	depends on MMU
 	help
 	  Keeps unevictable pages off of the active and inactive pageout
 	  lists, so kswapd will not waste CPU time or have its balancing



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>