linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@surriel.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@saeurebad.de>,
	linux-mm@kvack.org
Subject: Re: [RFC][PATCH -mm] vmscan: fix swapout on sequential IO
Date: Thu, 24 Jul 2008 08:20:10 -0400	[thread overview]
Message-ID: <20080724082010.49546f60@bree.surriel.com> (raw)
In-Reply-To: <20080724152555.869D.KOSAKI.MOTOHIRO@jp.fujitsu.com>

On Thu, 24 Jul 2008 15:26:44 +0900
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> > -			zone->lru[l].nr_scan += scan + 1;
> > +			zone->lru[l].nr_scan += scan + force_scan;
> >  			nr[l] = zone->lru[l].nr_scan;
> >  			if (nr[l] >= sc->swap_cluster_max)
> >  				zone->lru[l].nr_scan = 0;
> 
> looks good to me.
> 
> 	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

I'm still benchmarking it, against 2.6.26, 2.6.26-rc8-mm1 and
2.6.26-rc8-mm1 with the "evict cache first" patch.

So far the results look promising.  I hope to publish the
benchmark results later today, when I have a full set of
all tests against all these kernels.

I have been running tests for about a week now.

-- 
All rights reversed.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2008-07-24 12:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23 18:41 Rik van Riel, Rik van Riel
2008-07-23 18:48 ` Johannes Weiner
2008-07-23 19:29   ` Rik van Riel
2008-07-23 19:38     ` Johannes Weiner
2008-07-24  6:26 ` KOSAKI Motohiro
2008-07-24 12:20   ` Rik van Riel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080724082010.49546f60@bree.surriel.com \
    --to=riel@surriel.com \
    --cc=hannes@saeurebad.de \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox