From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: Matt Mackall <mpm@selenic.com>
Cc: penberg@cs.helsinki.fi, cl@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
rdunlap@xenotime.net
Subject: Re: [RFC PATCH 4/4] kmemtrace: SLOB hooks.
Date: Wed, 23 Jul 2008 00:07:52 +0300 [thread overview]
Message-ID: <20080722210751.GA14810@localhost> (raw)
In-Reply-To: <1216760035.15519.113.camel@calx>
On Tue, Jul 22, 2008 at 03:53:55PM -0500, Matt Mackall wrote:
>
> On Tue, 2008-07-22 at 21:36 +0300, Eduard - Gabriel Munteanu wrote:
> > -static inline void *kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags)
> > +static __always_inline void *kmem_cache_alloc(struct kmem_cache *cachep,
> > + gfp_t flags)
> > {
> > return kmem_cache_alloc_node(cachep, flags, -1);
> > }
>
> Why is this needed? builtin_return?
If we don't use __always_inline, we can't be sure whether it's inlined
or not. And we don't know if we need _THIS_IP_ or _RET_IP_ (equivalent
to __builtin_return_address(0)). Simple, plain 'inline' does not
guarantee GCC will inline that function, nor does it warn us if it is
not inlined.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-07-22 21:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 18:36 [RFC PATCH 0/4] kmemtrace RFC (resend 2, fixed wrong Cc) Eduard - Gabriel Munteanu
2008-07-22 18:36 ` [RFC PATCH 1/4] kmemtrace: Core implementation Eduard - Gabriel Munteanu
2008-07-22 18:36 ` [RFC PATCH 2/4] kmemtrace: SLAB hooks Eduard - Gabriel Munteanu
2008-07-22 18:36 ` [RFC PATCH 3/4] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-07-22 18:36 ` [RFC PATCH 4/4] kmemtrace: SLOB hooks Eduard - Gabriel Munteanu
2008-07-22 20:53 ` Matt Mackall
2008-07-22 21:07 ` Eduard - Gabriel Munteanu [this message]
2008-07-28 9:41 ` Pekka Enberg
2008-07-28 9:40 ` [RFC PATCH 3/4] kmemtrace: SLUB hooks Pekka Enberg
2008-07-28 9:37 ` [RFC PATCH 2/4] kmemtrace: SLAB hooks Pekka Enberg
2008-07-28 9:24 ` [RFC PATCH 1/4] kmemtrace: Core implementation Pekka Enberg
2008-07-28 16:29 ` Mathieu Desnoyers
2008-07-28 17:09 ` Matt Mackall
2008-07-28 17:35 ` Eduard - Gabriel Munteanu
2008-07-29 8:25 ` Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2008-07-22 18:31 [RFC PATCH 0/4] kmemtrace RFC (resend 2) Eduard - Gabriel Munteanu
2008-07-22 18:31 ` [RFC PATCH 1/4] kmemtrace: Core implementation Eduard - Gabriel Munteanu
2008-07-22 18:31 ` [RFC PATCH 2/4] kmemtrace: SLAB hooks Eduard - Gabriel Munteanu
2008-07-22 18:31 ` [RFC PATCH 3/4] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-07-22 18:31 ` [RFC PATCH 4/4] kmemtrace: SLOB hooks Eduard - Gabriel Munteanu
2008-07-17 0:46 [RFC PATCH 0/4] kmemtrace RFC (resubmit 1) Eduard - Gabriel Munteanu
2008-07-17 0:46 ` [RFC PATCH 1/4] kmemtrace: Core implementation Eduard - Gabriel Munteanu
2008-07-17 0:46 ` [RFC PATCH 2/4] kmemtrace: SLAB hooks Eduard - Gabriel Munteanu
2008-07-17 0:46 ` [RFC PATCH 3/4] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-07-17 0:46 ` [RFC PATCH 4/4] kmemtrace: SLOB hooks Eduard - Gabriel Munteanu
2008-07-17 7:43 ` Pekka Enberg
2008-07-17 15:46 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722210751.GA14810@localhost \
--to=eduard.munteanu@linux360.ro \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox