From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 22 Jul 2008 01:40:43 -0700 From: Andrew Morton Subject: Re: [PATCH 1/2][-mm][resend] res_counter limit change support ebusy Message-Id: <20080722014043.92272350.akpm@linux-foundation.org> In-Reply-To: <20080714171154.e1cc9943.kamezawa.hiroyu@jp.fujitsu.com> References: <20080714171154.e1cc9943.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "balbir@linux.vnet.ibm.com" , "xemul@openvz.org" , LKML List-ID: On Mon, 14 Jul 2008 17:11:54 +0900 KAMEZAWA Hiroyuki wrote: > +static inline int res_counter_set_limit(struct res_counter *cnt, > + unsigned long long limit) > +{ > + unsigned long flags; > + int ret = -EBUSY; > + > + spin_lock_irqsave(&cnt->lock, flags); > + if (cnt->usage < limit) { > + cnt->limit = limit; > + ret = 0; > + } > + spin_unlock_irqrestore(&cnt->lock, flags); > + return ret; > +} Need I say it? This function is waaaaaay too large to be inlined. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org