linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Johannes Weiner <hannes@saeurebad.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Nossum <vegard.nossum@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] mm: more likely reclaim MADV_SEQUENTIAL mappings
Date: Mon, 21 Jul 2008 22:36:09 -0400	[thread overview]
Message-ID: <20080721223609.70e93725@bree.surriel.com> (raw)
In-Reply-To: <200807221202.27169.nickpiggin@yahoo.com.au>

On Tue, 22 Jul 2008 12:02:26 +1000
Nick Piggin <nickpiggin@yahoo.com.au> wrote:

> I don't actually care what the man page or posix says if it is obviously
> silly behaviour. If you want to dispute the technical points of my post,
> that would be helpful.

Application writers read the man page and expect MADV_SEQUENTIAL
to do roughly what the name and description imply.

If you think that the kernel should not bother implementing
what the application writers expect, and the application writers
should implement special drop-behind magic for Linux, your
expectations may not be entirely realistic.

> Consider this: if the app already has dedicated knowledge and
> syscalls to know about this big sequential copy, then it should
> go about doing it the *right* way and really get performance
> improvement. Automatic unmap-behind even if it was perfect still
> needs to scan LRU lists to reclaim.

Doing nothing _also_ ends up with the kernel scanning the
LRU lists, once memory fills up.

Scanning the LRU lists is a given.

All that the patch by Johannes does is make sure the kernel
does the right thing when it runs into an MADV_SEQUENTIAL
page on the inactive_file list: evict the page immediately,
instead of having it pass through the active list and the
inactive list again.  

This reduces the number of times that MADV_SEQUENTIAL pages
get scanned from 3 to 1, while protecting the working set
from MADV_SEQUENTIAL pages.

-- 
All rights reversed.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-07-22  2:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-19 17:31 Johannes Weiner
2008-07-19 17:59 ` Rik van Riel
2008-07-21  0:09 ` KOSAKI Motohiro
2008-07-21  1:48   ` Andrew Morton
2008-07-21  3:53     ` KOSAKI Motohiro
2008-07-21  5:49     ` Nick Piggin
2008-07-21 15:14       ` Rik van Riel
2008-07-22  2:02         ` Nick Piggin
2008-07-22  2:36           ` Rik van Riel [this message]
2008-07-22  2:54             ` Nick Piggin
2008-07-22  3:04               ` Rik van Riel
2008-07-22  3:43                 ` Nick Piggin
2008-07-22  3:49                   ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080721223609.70e93725@bree.surriel.com \
    --to=riel@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@saeurebad.de \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=peterz@infradead.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox