Re: [RFC PATCH 5/5] kmemtrace: SLOB hooks.

[Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>]

On Fri, 11 Jul 2008 10:36:37 -0500
Matt Mackall <mpm@selenic.com> wrote:

> 
> On Fri, 2008-07-11 at 11:44 +0300, Pekka Enberg wrote:
> > Hi,
> > 
> > Matt, can you take a look at this? I know you don't want *debugging*
> > code in SLOB but this is for instrumentation.
> 
> I presume this code all disappears in a default SLOB build?

Yes, of course. If CONFIG_KMEMTRACE is disabled, those calls go into
empty static inlines.
 
> > On Thu, Jul 10, 2008 at 9:06 PM, Eduard - Gabriel Munteanu
> > <eduard.munteanu@linux360.ro> wrote:
> > > This adds hooks for the SLOB allocator, to allow tracing with
> > > kmemtrace.
> > >
> > > Signed-off-by: Eduard - Gabriel Munteanu
> > > <eduard.munteanu@linux360.ro> ---
> > >  mm/slob.c |   37 +++++++++++++++++++++++++++++++------
> > >  1 files changed, 31 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/mm/slob.c b/mm/slob.c
> > > index a3ad667..44f395a 100644
> > > --- a/mm/slob.c
> > > +++ b/mm/slob.c
> > > @@ -65,6 +65,7 @@
> > >  #include <linux/module.h>
> > >  #include <linux/rcupdate.h>
> > >  #include <linux/list.h>
> > > +#include <linux/kmemtrace.h>
> > >  #include <asm/atomic.h>
> > >
> > >  /*
> > > @@ -463,27 +464,38 @@ void *__kmalloc_node(size_t size, gfp_t
> > > gfp, int node) {
> > >        unsigned int *m;
> > >        int align = max(ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN);
> > > +       void *ret;
> 
> There's tons of tab damage in this patch. Or perhaps it's just been
> mangled by someone's mailer?

I know :-(. This was intended as a simple RFC, things will change on
subsequent submissions.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>