From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Jack Steiner <steiner@sgi.com>
Cc: Hugh Dickins <hugh@veritas.com>,
Christoph Hellwig <hch@infradead.org>,
cl@linux-foundation.org, akpm@osdl.org,
linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
holt@sgi.com, andrea@qumranet.com, linux-mm@kvack.org
Subject: Re: [patch 12/13] GRU Driver V3 - export is_uv_system(), zap_page_range() & follow_page()
Date: Fri, 11 Jul 2008 00:21:28 +1000 [thread overview]
Message-ID: <200807110021.29392.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <20080710132903.GA17830@sgi.com>
On Thursday 10 July 2008 23:29, Jack Steiner wrote:
> On Thu, Jul 10, 2008 at 05:31:54PM +1000, Nick Piggin wrote:
> > On Thursday 10 July 2008 05:11, Jack Steiner wrote:
> > > I'll post the new GRU patch in a few minutes.
> >
> > It looks broken to me. How does it determine whether it has a
> > normal page or not?
>
> Right. Hugepages are not currently supported by the GRU. There is code that
> I know is missing/broken in this path. I'm trying to get the core driver
> accepted, then I'll get the portion dealing with hugepages working.
Oh, I meant "normal" pages as in vm_normal_page(), or is there some
other reason this codepath is exempt from them?
Using gup.c code I don't think will prevent your driver from getting
accepted. Conversely, I would not like the open coded page table walk
to go upstream...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-07-10 14:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080703213348.489120321@attica.americas.sgi.com>
[not found] ` <20080703213633.890647632@attica.americas.sgi.com>
[not found] ` <20080704073926.GA1449@infradead.org>
2008-07-07 14:39 ` Jack Steiner
2008-07-07 14:54 ` Andrea Arcangeli
2008-07-07 16:29 ` Hugh Dickins
2008-07-07 16:53 ` Jack Steiner
2008-07-08 2:16 ` Nick Piggin
2008-07-09 19:11 ` Jack Steiner
2008-07-10 7:31 ` Nick Piggin
2008-07-10 13:29 ` Jack Steiner
2008-07-10 14:21 ` Nick Piggin [this message]
2008-07-10 16:33 ` Jack Steiner
2008-07-10 16:52 ` Nick Piggin
2008-07-10 17:20 ` Jack Steiner
2008-07-11 3:30 ` Nick Piggin
2008-07-07 18:58 ` Arjan van de Ven
2008-07-07 19:29 ` Jack Steiner
2008-07-07 21:03 ` Andrea Arcangeli
2008-07-07 17:58 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807110021.29392.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=andrea@qumranet.com \
--cc=cl@linux-foundation.org \
--cc=hch@infradead.org \
--cc=holt@sgi.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox