linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: npiggin@suse.de
Cc: mel@csn.ul.ie, agl@us.ibm.com, akpm@linux-foudation.org,
	linux-mm@kvack.org
Subject: [RFC PATCH 4/4] hugetlb: remove CONFIG_SYSFS dependency
Date: Tue, 8 Jul 2008 11:08:26 -0700	[thread overview]
Message-ID: <20080708180826.GF14908@us.ibm.com> (raw)
In-Reply-To: <20080708180751.GE14908@us.ibm.com>

I incorrectly made the hugetlb kobject functionality depend on SYSFS,
when, in fact, the kobject functions fully work even with out sysfs.
Without sysfs, there is no interface to manipulate the attributes of the
various hugetlb kobjects, but they still exist.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 9c24f8f..a432889 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1130,7 +1130,6 @@ out:
 	return ret;
 }
 
-#ifdef CONFIG_SYSFS
 #define HSTATE_ATTR_RO(_name) \
 	static struct kobj_attribute _name##_attr = __ATTR_RO(_name)
 
@@ -1282,12 +1281,6 @@ static void __exit hugetlb_exit(void)
 }
 module_exit(hugetlb_exit);
 
-#else
-static void __init hugetlb_sysfs_init(void)
-{
-}
-#endif
-
 static int __init hugetlb_init(void)
 {
 	BUILD_BUG_ON(HPAGE_SHIFT == 0);

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-07-08 18:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08 18:03 [RFC PATCH 0/4] -mm-only hugetlb updates Nishanth Aravamudan
2008-07-08 18:05 ` [RFC PATCH 1/4] mm: remove mm_init compilation dependency on CONFIG_DEBUG_MEMORY_INIT Nishanth Aravamudan
2008-07-08 18:06   ` [RFC PATCH 2/4] mm: create /sys/kernel/mm Nishanth Aravamudan
2008-07-08 18:07     ` [RFC PATCH 3/4] hugetlb: hang off of /sys/kernel/mm rather than /sys/kernel Nishanth Aravamudan
2008-07-08 18:08       ` Nishanth Aravamudan [this message]
2008-07-10 17:39       ` Mel Gorman
2008-07-10 17:24     ` [RFC PATCH 2/4] mm: create /sys/kernel/mm Mel Gorman
2008-07-10 16:35   ` [RFC PATCH 1/4] mm: remove mm_init compilation dependency on CONFIG_DEBUG_MEMORY_INIT Mel Gorman
2008-07-08 18:13 ` [RFC PATCH 0/4] -mm-only hugetlb updates Nishanth Aravamudan
2008-07-10 13:11 ` Nick Piggin
2008-07-10 16:50   ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080708180826.GF14908@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=agl@us.ibm.com \
    --cc=akpm@linux-foudation.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox