Re: Fw: [PATCH] Add alloc_pages_exact() and free_pages_exact()

[Nick Piggin <nickpiggin@yahoo.com.au>]

On Thursday 26 June 2008 00:25, Timur Tabi wrote:
> Nick Piggin wrote:
> > On Wednesday 25 June 2008 06:57, Andrew Morton wrote:
> >> I'm applying this.
> >
> > Fine. And IIRC there are one or two places around the kernel that
> > could be converted to use it. Why not just have a node id
> > argument and call it alloc_pages_node_exact? so Christoph doesn't
> > have to do it himself ;)
>
> Since I don't know anything nodes, I can't say whether this is a good idea
> or not, or even how to implement it.  Sorry.

Just give an 'int nid' parameter, and then pass it through to
alloc_pages_node. You don't have to do anything with it directly.


> > Maybe you could also say that __GFP_COMPOUND cannot be used, and
> > that the returned pages are "split" (work the same way as N
> > indivudually allocated order-0 pages WRT refcounting).
>
> Is this a suggestion for the function comments?

Yes, just comments.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>