From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC 5/5] Memory controller soft limit reclaim on contention
Date: Sat, 28 Jun 2008 13:22:47 +0900 [thread overview]
Message-ID: <20080628132247.01e1ed30.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20080627151906.31664.7247.sendpatchset@balbir-laptop>
On Fri, 27 Jun 2008 20:49:06 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> +
> + while (count-- &&
> + ((mem = heap_delete_max(&mem_cgroup_heap)) != NULL)) {
> + BUG_ON(!mem->on_heap);
> + spin_unlock_irqrestore(&mem_cgroup_heap_lock, flags);
> + nr_reclaimed += try_to_free_mem_cgroup_pages(mem,
> + gfp_mask);
> + cond_resched();
> + spin_lock_irqsave(&mem_cgroup_heap_lock, flags);
> + mem->on_heap = 0;
It seems "mem* is not on heap after heap_delete_max(), right ?
If so, I think this on_heap should be cleared right after heap_delete_max().
> + /*
> + * What should be the basis of breaking out?
> + */
> + if (nr_reclaimed)
> + goto done;
why stops here ?
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-28 4:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 15:18 [RFC 0/5] Memory controller soft limit introduction (v3) Balbir Singh
2008-06-27 15:18 ` [RFC 1/5] Memory controller soft limit documentation Balbir Singh
2008-06-27 15:18 ` [RFC 2/5] Add delete max to prio heap Balbir Singh
2008-06-27 15:18 ` [RFC 3/5] Replacement policy on heap overfull Balbir Singh
2008-06-27 15:37 ` Paul Menage
2008-06-30 3:46 ` Balbir Singh
2008-06-27 15:18 ` [RFC 4/5] Memory controller soft limit resource counter additions Balbir Singh
2008-06-27 15:19 ` [RFC 5/5] Memory controller soft limit reclaim on contention Balbir Singh
2008-06-27 16:09 ` Paul Menage
2008-06-29 4:48 ` Balbir Singh
2008-06-30 3:42 ` Balbir Singh
2008-06-28 4:22 ` KAMEZAWA Hiroyuki [this message]
2008-06-30 7:33 ` KOSAKI Motohiro
2008-06-30 7:48 ` Balbir Singh
2008-06-30 7:56 ` KOSAKI Motohiro
2008-06-30 8:11 ` Balbir Singh
2008-06-30 8:17 ` KOSAKI Motohiro
2008-06-28 4:36 ` [RFC 0/5] Memory controller soft limit introduction (v3) KAMEZAWA Hiroyuki
2008-06-29 5:02 ` Balbir Singh
2008-06-30 1:20 ` KAMEZAWA Hiroyuki
2008-06-30 1:50 ` KAMEZAWA Hiroyuki
2008-06-30 2:02 ` KAMEZAWA Hiroyuki
2008-06-30 3:41 ` Balbir Singh
2008-06-30 3:57 ` KAMEZAWA Hiroyuki
2008-06-30 4:00 ` Balbir Singh
2008-06-30 4:19 ` KAMEZAWA Hiroyuki
2008-06-30 4:40 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080628132247.01e1ed30.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox