From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 25 Jun 2008 19:09:06 +0900 From: KOSAKI Motohiro Subject: [-mm][PATCH 8/10] fix shmem page migration incorrectness on memcgroup In-Reply-To: <20080625185717.D84C.KOSAKI.MOTOHIRO@jp.fujitsu.com> References: <20080625185717.D84C.KOSAKI.MOTOHIRO@jp.fujitsu.com> Message-Id: <20080625190750.D864.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: LKML , linux-mm , Andrew Morton , Lee Schermerhorn , Rik van Riel , KAMEZAWA Hiroyuki , Daisuke Nishimura Cc: kosaki.motohiro@jp.fujitsu.com List-ID: = From: KAMEZAWA Hiroyuki mem_cgroup_uncharge() against old page is done after radix-tree-replacement. And there were special handling to ingore swap-cache page. But, shmem can be swap-cache and file-cache at the same time. Chekcing PageSwapCache() is not correct here. Check PageAnon() instead. Signed-off-by: KAMEZAWA Hiroyuki Acked-by: Daisuke Nishimura Signed-off-by: KOSAKI Motohiro --- mm/migrate.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) Index: b/mm/migrate.c =================================================================== --- a/mm/migrate.c +++ b/mm/migrate.c @@ -332,7 +332,13 @@ static int migrate_page_move_mapping(str __inc_zone_page_state(newpage, NR_FILE_PAGES); spin_unlock_irq(&mapping->tree_lock); - if (!PageSwapCache(newpage)) + + /* + * The page is removed from radix-tree implicitly. + * We uncharge it here but swap cache of anonymous page should be + * uncharged by mem_cgroup_ucharge_page(). + */ + if (!PageAnon(newpage)) mem_cgroup_uncharge_cache_page(page); return 0; @@ -381,7 +387,8 @@ static void migrate_page_copy(struct pag /* * SwapCache is removed implicitly. Uncharge against swapcache * should be called after ClearPageSwapCache() because - * mem_cgroup_uncharge_page checks the flag. + * mem_cgroup_uncharge_page checks the flag. shmem's swap cache + * is uncharged before here. */ mem_cgroup_uncharge_page(page); } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org