From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: jens.axboe@oracle.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
torvalds@linux-foundation.org, npiggin@suse.de
Subject: Re: [rfc patch 2/4] splice: remove steal from pipe_buf_operations
Date: Tue, 24 Jun 2008 22:21:34 +1000 [thread overview]
Message-ID: <200806242221.35304.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <E1KB4EV-0000u3-5j@pomaz-ex.szeredi.hu>
On Tuesday 24 June 2008 18:50, Miklos Szeredi wrote:
> > On Sat, Jun 21 2008, Miklos Szeredi wrote:
> > > From: Miklos Szeredi <mszeredi@suse.cz>
> > >
> > > The 'steal' operation hasn't been used for some time. Remove it and
> > > the associated dead code. If it's needed in the future, it can always
> > > be easily restored.
> >
> > I'd rather not just remove this, it's basically waiting for Nick to make
> > good on his promise to make stealing work again (he disabled it).
>
> Yes, I read the commit log. He disabled it with the intent that we
> may or may not want this interface back, and possibly in some other
> form.
>
> Jens, does somebody need this feature? What for? If not, then I
> guess nobody will bother implementing it.
>
> (Nick CC-d)
I've kind of wanted to implement it "because it is cool", but also
because I hoped to ensure the new write_begin/write_end APIs would
be general enough to support it.
Unfortunately I'm not aware of a killer feature so it's kept going
down the todo pile. However it really is one of those things where
you need the API to work before you get programs emerging that make
interesting uses out of it. I think if it can be done without adding
complication to pagecache/filesystem code, then it would be nice.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-24 12:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-21 15:46 [rfc patch 0/4] splice: cleanups and fixes Miklos Szeredi
2008-06-21 15:46 ` [rfc patch 1/4] splice: fix comment Miklos Szeredi, Miklos Szeredi
2008-06-21 15:46 ` [rfc patch 2/4] splice: remove steal from pipe_buf_operations Miklos Szeredi, Miklos Szeredi
2008-06-24 8:01 ` Jens Axboe
2008-06-24 8:50 ` Miklos Szeredi
2008-06-24 12:21 ` Nick Piggin [this message]
2008-06-21 15:46 ` [rfc patch 3/4] splice: remove confirm " Miklos Szeredi, Miklos Szeredi
2008-06-24 8:04 ` Jens Axboe
2008-06-24 8:54 ` Miklos Szeredi
2008-06-24 11:19 ` Jens Axboe
2008-06-24 11:36 ` Miklos Szeredi
2008-06-24 11:46 ` Evgeniy Polyakov
2008-06-24 12:02 ` Miklos Szeredi
2008-06-24 12:15 ` Evgeniy Polyakov
2008-06-24 12:16 ` Nick Piggin
2008-06-24 12:22 ` Jens Axboe
2008-06-24 13:00 ` Miklos Szeredi
2008-06-24 17:30 ` Linus Torvalds
2008-06-24 18:24 ` Miklos Szeredi
2008-06-24 18:31 ` Linus Torvalds
2008-06-24 19:05 ` Miklos Szeredi
2008-06-24 19:17 ` Linus Torvalds
2008-06-24 19:24 ` Miklos Szeredi
2008-06-24 19:26 ` Miklos Szeredi
2008-06-24 19:32 ` Miklos Szeredi
2008-06-24 19:47 ` Linus Torvalds
2008-06-24 20:06 ` Miklos Szeredi
2008-06-24 19:45 ` Linus Torvalds
2008-06-21 15:46 ` [rfc patch 4/4] splice: use do_generic_file_read() Miklos Szeredi, Miklos Szeredi
2008-06-24 8:05 ` Jens Axboe
2008-06-24 11:11 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806242221.35304.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=npiggin@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox