From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 24 Jun 2008 18:59:28 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC][PATCH] putback_lru_page()/unevictable page handling rework v3 Message-Id: <20080624185928.e06a79f7.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20080624184122.D838.KOSAKI.MOTOHIRO@jp.fujitsu.com> References: <20080621185408.E832.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080624184122.D838.KOSAKI.MOTOHIRO@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KOSAKI Motohiro Cc: Lee Schermerhorn , linux-mm , LKML List-ID: On Tue, 24 Jun 2008 18:49:05 +0900 KOSAKI Motohiro wrote: > > + mem_cgroup_move_lists(page, lru); > > + > > + /* > > + * page's status can change while we move it among lru. If an evictable > > + * page is on unevictable list, it never be freed. To avoid that, > > + * check after we added it to the list, again. > > + */ > > + if (lru == LRU_UNEVICTABLE && page_evictable(page, NULL)) { > > + if (!isolate_lru_page(page)) { > > + put_page(page); > > + goto redo; > > at this point, We should call ClearPageUnevictable(). > otherwise, BUG() is called on isolate_lru_pages(). > Sure. thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org