From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] putback_lru_page()/unevictable page handling rework v3
Date: Tue, 24 Jun 2008 18:59:28 +0900 [thread overview]
Message-ID: <20080624185928.e06a79f7.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <20080624184122.D838.KOSAKI.MOTOHIRO@jp.fujitsu.com>
On Tue, 24 Jun 2008 18:49:05 +0900
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > + mem_cgroup_move_lists(page, lru);
> > +
> > + /*
> > + * page's status can change while we move it among lru. If an evictable
> > + * page is on unevictable list, it never be freed. To avoid that,
> > + * check after we added it to the list, again.
> > + */
> > + if (lru == LRU_UNEVICTABLE && page_evictable(page, NULL)) {
> > + if (!isolate_lru_page(page)) {
> > + put_page(page);
> > + goto redo;
>
> at this point, We should call ClearPageUnevictable().
> otherwise, BUG() is called on isolate_lru_pages().
>
Sure. thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-24 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-21 10:00 KOSAKI Motohiro
2008-06-24 2:43 ` KOSAKI Motohiro
2008-06-24 17:10 ` Lee Schermerhorn
2008-06-24 17:55 ` Andrew Morton
2008-06-24 19:11 ` Lee Schermerhorn
2008-06-24 19:19 ` Andrew Morton
2008-06-24 17:29 ` [PATCH] fix2 to " Lee Schermerhorn
2008-06-24 17:38 ` KOSAKI Motohiro
2008-06-24 9:49 ` [RFC][PATCH] " KOSAKI Motohiro
2008-06-24 9:59 ` KAMEZAWA Hiroyuki [this message]
2008-06-24 17:15 ` Lee Schermerhorn
2008-06-24 17:19 ` [PATCH] fix to " Lee Schermerhorn
2008-06-24 17:35 ` KOSAKI Motohiro
2008-06-24 17:48 ` Lee Schermerhorn
2008-06-24 18:19 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080624185928.e06a79f7.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox