From: Nick Piggin <npiggin@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Hugh Dickins <hugh@veritas.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] mm: fix race in COW logic
Date: Mon, 23 Jun 2008 03:52:43 +0200 [thread overview]
Message-ID: <20080623015243.GB29413@wotan.suse.de> (raw)
In-Reply-To: <alpine.LFD.1.10.0806221033200.2926@woody.linux-foundation.org>
On Sun, Jun 22, 2008 at 10:35:50AM -0700, Linus Torvalds wrote:
>
>
> On Sun, 22 Jun 2008, Hugh Dickins wrote:
> >
> > You have a wicked mind, and I think you're right, and the fix right.
>
> Agreed. I think the patch is fine, although I'd personally probably like
> it even more if the mm counter updates to follow the rmap updates.
I would definitely have done that except it would want updating everywhere
else too, making the patch a bugfix+more (and mixing subtle issues that
may very well need bisecting some day!).
As you see in the changelog, I would prefer that too. I can make a followup
to move all the counter updates afterward, and eliminate this branch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-06-23 1:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 15:30 Nick Piggin
2008-06-22 17:11 ` Hugh Dickins
2008-06-22 17:35 ` Linus Torvalds
2008-06-22 18:10 ` Hugh Dickins
2008-06-22 18:18 ` Linus Torvalds
2008-06-23 1:49 ` Nick Piggin
2008-06-23 10:04 ` Hugh Dickins
2008-06-23 12:18 ` Nick Piggin
2008-06-23 12:30 ` Nick Piggin
2008-06-23 15:39 ` Hugh Dickins
2008-06-27 9:19 ` Peter Zijlstra
2008-06-27 9:13 ` Peter Zijlstra
2008-06-23 1:52 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623015243.GB29413@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox