From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 18 Jun 2008 00:33:18 +0900 From: KOSAKI Motohiro Subject: Re: [PATCH][RFC] fix kernel BUG at mm/migrate.c:719! in 2.6.26-rc5-mm3 In-Reply-To: <20080617163501.7cf411ee.nishimura@mxp.nes.nec.co.jp> References: <20080611225945.4da7bb7f.akpm@linux-foundation.org> <20080617163501.7cf411ee.nishimura@mxp.nes.nec.co.jp> Message-Id: <20080618003129.DE27.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Daisuke Nishimura Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , Rik van Riel , Lee Schermerhorn , Nick Piggin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org List-ID: > @@ -715,13 +725,7 @@ unlock: > * restored. > */ > list_del(&page->lru); > - if (!page->mapping) { > - VM_BUG_ON(page_count(page) != 1); > - unlock_page(page); > - put_page(page); /* just free the old page */ > - goto end_migration; > - } else > - unlock = putback_lru_page(page); > + unlock = putback_lru_page(page); > } > > if (unlock) this part is really necessary? I tryed to remove it, but any problem doesn't happend. Of cource, another part is definitly necessary for specurative pagecache :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org