From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: hans.rosenfeld@amd.com, mpm@selenic.com, linux-mm@kvack.org
Subject: Re: [v4][PATCH 2/2] fix large pages in pagemap
Date: Wed, 11 Jun 2008 12:37:24 -0700 [thread overview]
Message-ID: <20080611123724.3a79ea61.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080611180230.7459973B@kernel>
On Wed, 11 Jun 2008 11:02:31 -0700
Dave Hansen <dave@linux.vnet.ibm.com> wrote:
>
> We were walking right into huge page areas in the pagemap
> walker, and calling the pmds pmd_bad() and clearing them.
>
> That leaked huge pages. Bad.
>
> This patch at least works around that for now. It ignores
> huge pages in the pagemap walker for the time being, and
> won't leak those pages.
>
I don't get it. Why can't we just stick a
if (pmd_huge(pmd))
continue;
into pagemap_pte_range()? Or something like that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-11 19:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 18:02 [v4][PATCH 1/2] pass mm into pagewalkers Dave Hansen
2008-06-11 18:02 ` [v4][PATCH 2/2] fix large pages in pagemap Dave Hansen
2008-06-11 19:37 ` Andrew Morton [this message]
2008-06-11 19:53 ` Matt Mackall
2008-06-11 20:11 ` Andrew Morton
2008-06-11 20:21 ` Matt Mackall
2008-06-11 20:34 ` Dave Hansen
2008-06-11 20:52 ` Andrew Morton
2008-06-11 21:01 ` Rik van Riel
2008-06-11 21:23 ` Dave Hansen
2008-06-11 22:37 ` Matt Mackall
2008-06-12 21:36 ` Hugh Dickins
2008-06-12 22:35 ` Matt Mackall
2008-06-11 20:15 ` Dave Hansen
2008-06-11 19:35 ` [v4][PATCH 1/2] pass mm into pagewalkers Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611123724.3a79ea61.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hans.rosenfeld@amd.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox