From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: linuxppc-dev list <Linuxppc-dev@ozlabs.org>
Cc: linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [RFC:PATCH 01/06] powerpc: hash_huge_page() should get the WIMG bits from the lpte
Date: Tue, 10 Jun 2008 18:01:01 -0400 [thread overview]
Message-ID: <20080610220101.10257.57966.sendpatchset@norville.austin.ibm.com> (raw)
In-Reply-To: <20080610220055.10257.84465.sendpatchset@norville.austin.ibm.com>
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
---
arch/powerpc/mm/hugetlbpage.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff -Nurp linux000/arch/powerpc/mm/hugetlbpage.c linux001/arch/powerpc/mm/hugetlbpage.c
--- linux000/arch/powerpc/mm/hugetlbpage.c 2008-04-16 21:49:44.000000000 -0500
+++ linux001/arch/powerpc/mm/hugetlbpage.c 2008-06-10 16:48:59.000000000 -0500
@@ -502,9 +502,8 @@ repeat:
new_pte = (new_pte & ~_PAGE_HPTEFLAGS) | _PAGE_HASHPTE;
/* Add in WIMG bits */
- /* XXX We should store these in the pte */
- /* --BenH: I think they are ... */
- rflags |= _PAGE_COHERENT;
+ rflags |= (new_pte & (_PAGE_WRITETHRU | _PAGE_NO_CACHE |
+ _PAGE_COHERENT | _PAGE_GUARDED));
/* Insert into the hash table, primary slot */
slot = ppc_md.hpte_insert(hpte_group, va, pa, rflags, 0,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-10 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 22:00 [RFC:PATCH 00/06] Strong Access Ordering page attributes for POWER7 Dave Kleikamp
2008-06-10 22:01 ` Dave Kleikamp [this message]
2008-06-10 22:01 ` [RFC:PATCH 02/06] mm: Allow architectures to define additional protection bits Dave Kleikamp
2008-06-10 22:14 ` Andrew Morton
2008-06-11 15:47 ` Dave Kleikamp
2008-06-10 22:01 ` [RFC:PATCH 03/06] powerpc: Define flags for Strong Access Ordering Dave Kleikamp
2008-06-10 22:01 ` [RFC:PATCH 04/06] powerpc: Define CPU_FTR_SAO Dave Kleikamp
2008-06-10 22:01 ` [RFC:PATCH 05/06] powerpc: Add Strong Access Ordering Dave Kleikamp
2008-06-10 22:01 ` [RFC:PATCH 06/06] powerpc: Don't clear _PAGE_COHERENT when _PAGE_SAO is set Dave Kleikamp
2008-06-10 22:26 ` Sergei Shtylyov
2008-06-11 3:12 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080610220101.10257.57966.sendpatchset@norville.austin.ibm.com \
--to=shaggy@linux.vnet.ibm.com \
--cc=Linuxppc-dev@ozlabs.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox