From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 2 Jun 2008 16:58:47 -0700 From: Andrew Morton Subject: Re: [patch 1/5] x86: implement pte_special Message-Id: <20080602165847.dd19ddb1.akpm@linux-foundation.org> In-Reply-To: <20080529122602.062780000@nick.local0.net> References: <20080529122050.823438000@nick.local0.net> <20080529122602.062780000@nick.local0.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: npiggin@suse.de Cc: shaggy@austin.ibm.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, apw@shadowen.org List-ID: On Thu, 29 May 2008 22:20:51 +1000 npiggin@suse.de wrote: > Implement the pte_special bit for x86. This is required to support lockless > get_user_pages, because we need to know whether or not we can refcount a > particular page given only its pte (and no vma). Spits this reject: *************** *** 39,44 **** #define _PAGE_UNUSED3 (_AC(1, L)<<_PAGE_BIT_UNUSED3) #define _PAGE_PAT (_AC(1, L)<<_PAGE_BIT_PAT) #define _PAGE_PAT_LARGE (_AC(1, L)<<_PAGE_BIT_PAT_LARGE) #if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE) #define _PAGE_NX (_AC(1, ULL) << _PAGE_BIT_NX) --- 40,47 ---- #define _PAGE_UNUSED3 (_AC(1, L)<<_PAGE_BIT_UNUSED3) #define _PAGE_PAT (_AC(1, L)<<_PAGE_BIT_PAT) #define _PAGE_PAT_LARGE (_AC(1, L)<<_PAGE_BIT_PAT_LARGE) + #define _PAGE_SPECIAL (_AC(1, L)<<_PAGE_BIT_SPECIAL) + #define __HAVE_ARCH_PTE_SPECIAL #if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE) #define _PAGE_NX (_AC(1, ULL) << _PAGE_BIT_NX) Which I fixed thusly: #define _PAGE_PAT (_AT(pteval_t, 1) << _PAGE_BIT_PAT) #define _PAGE_PAT_LARGE (_AT(pteval_t, 1) << _PAGE_BIT_PAT_LARGE) #define _PAGE_SPECIAL (_AT(pteval_t, 1) << _PAGE_BIT_SPECIAL) #define __HAVE_ARCH_PTE_SPECIAL OK? (Also please check the bunch of checkpatch fixes, a warning fix and a compile fix). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org