From: yamamoto@valinux.co.jp (YAMAMOTO Takashi)
To: kamezawa.hiroyu@jp.fujitsu.com
Cc: linux-mm@kvack.org, balbir@linux.vnet.ibm.com, xemul@openvz.org,
lizf@cn.fujitsu.com, containers@lists.osdl.org
Subject: Re: [RFC 2/4] memcg: high-low watermark
Date: Tue, 27 May 2008 14:30:27 +0900 (JST) [thread overview]
Message-ID: <20080527053027.E554A5A0A@siro.lan> (raw)
In-Reply-To: Your message of "Tue, 27 May 2008 14:07:03 +0900" <20080527140703.97b69ed3.kamezawa.hiroyu@jp.fujitsu.com>
> +enum res_state res_counter_state(struct res_counter *counter)
> +{
> + unsigned long flags;
> + enum res_state ret = RES_BELOW_LIMIT;
> +
> + spin_lock_irqsave(&counter->lock, flags);
> + if (counter->use_watermark) {
> + if (counter->usage <= counter->lwmark)
> + ret = RES_BELOW_LOW;
> + else if (counter->usage <= counter->hwmark)
> + ret = RES_BELOW_HIGH;
> + }
> + spin_unlock_irqrestore(&counter->lock, flags);
> + return ret;
> +}
can't it be RES_OVER_LIMIT?
eg. when you lower the limit.
YAMAMOTO Takashi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-27 5:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 5:01 [RFC 0/4] memcg: background reclaim (v1) KAMEZAWA Hiroyuki
2008-05-27 5:05 ` [RFC 1/4] memcg: drop pages at rmdir (v1) KAMEZAWA Hiroyuki
2008-05-27 16:11 ` Balbir Singh
2008-05-28 0:12 ` KAMEZAWA Hiroyuki
2008-05-27 5:07 ` [RFC 2/4] memcg: high-low watermark KAMEZAWA Hiroyuki
2008-05-27 5:30 ` YAMAMOTO Takashi [this message]
2008-05-27 7:14 ` KAMEZAWA Hiroyuki
2008-05-27 7:51 ` Li Zefan
2008-05-27 9:42 ` KAMEZAWA Hiroyuki
2008-05-27 16:26 ` Balbir Singh
2008-05-28 0:15 ` KAMEZAWA Hiroyuki
2008-05-27 5:08 ` [RFC 3/4] memcg: background reclaim KAMEZAWA Hiroyuki
2008-05-27 17:08 ` Balbir Singh
2008-05-28 0:45 ` KAMEZAWA Hiroyuki
2008-05-27 5:10 ` [RFC 4/4] memcg: NUMA " KAMEZAWA Hiroyuki
2008-05-27 17:26 ` Balbir Singh
2008-05-28 0:46 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080527053027.E554A5A0A@siro.lan \
--to=yamamoto@valinux.co.jp \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox