From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [RFC] Circular include dependencies
Date: Mon, 26 May 2008 22:10:06 +0900 [thread overview]
Message-ID: <20080526195803.F779.E1E9C6FF@jp.fujitsu.com> (raw)
In-Reply-To: <20080523181728.b30409b2.akpm@linux-foundation.org>
> On Fri, 23 May 2008 14:20:34 +0100 Russell King <rmk+lkml@arm.linux.org.uk> wrote:
>
> > Hi,
> >
> > Having discovered some circular include dependencies in the ARM header
> > files which were causing build issues, I created a script to walk ARM
> > includes and report any similar issues found - which includes traversing
> > any referenced linux/ includes.
> >
> > It identified the following two in include/linux/:
> >
> > linux/mmzone.h <- linux/memory_hotplug.h <- linux/mmzone.h
> > linux/mmzone.h <- linux/topology.h <- linux/mmzone.h
> >
> > Checking them by hand reveals that these are real. Whether they're
> > capable of causing a problem or not, I'm not going to comment on.
> > However, they're not a good idea and someone should probably look at
> > resolving the loops.
>
> (cc's added).
>
> Thanks.
>
> I'm not sure who we could tap for the topology.h one.
>
> A suitable (and often good) way of solving this is to identify the
> things which a.h needs from b.h and hoist them out into a new c.h and
> include that from both a.h and b.h.
Kame-san and I reviewed memory_hotplug.h.
We found its including was not necessary certainly.
This is the patch to fix it. I tested on IA64, and checked cross-compile
on powerpc. Kame-san tested this on x86-64.
Thanks for your report.
Bye.
----
Fix no need including of mmzone.h in memory_hotplug.h
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
---
include/linux/memory_hotplug.h | 1 -
1 file changed, 1 deletion(-)
Index: dptest/include/linux/memory_hotplug.h
===================================================================
--- dptest.orig/include/linux/memory_hotplug.h 2008-05-21 10:56:00.000000000 +0900
+++ dptest/include/linux/memory_hotplug.h 2008-05-26 20:32:06.000000000 +0900
@@ -1,7 +1,6 @@
#ifndef __LINUX_MEMORY_HOTPLUG_H
#define __LINUX_MEMORY_HOTPLUG_H
-#include <linux/mmzone.h>
#include <linux/spinlock.h>
#include <linux/notifier.h>
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-05-26 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080523132034.GB15384@flint.arm.linux.org.uk>
2008-05-24 1:17 ` Andrew Morton
2008-05-26 13:10 ` Yasunori Goto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526195803.F779.E1E9C6FF@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox