From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm@kvack.org,
Andrew Morton <akpm@osdl.org>,
Christoph Lameter <clameter@sgi.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] page-flags: record page flag overlays explicitly
Date: Mon, 26 May 2008 13:37:51 +0900 [thread overview]
Message-ID: <20080526132853.4661.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <1211560392.0@pinky>
Hi
Thank you nice patch.
> Some page flags are used for more than one purpose, for example
> PG_owner_priv_1. Currently there are individual accessors for each user,
> each built using the common flag name far away from the bit definitions.
> This makes it hard to see all possible uses of these bits.
>
> Now that we have a single enum to generate the bit orders it makes sense
> to express overlays in the same place. So create per use aliases for
> this bit in the main page-flags enum and use those in the accessors.
>
> Signed-off-by: Andy Whitcroft <apw@shadowen.org>
My review found no bug.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-26 4:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 16:33 [PATCH 0/3] explicitly document overloaded page flags V2 Andy Whitcroft
2008-05-23 16:33 ` [PATCH 1/3] page-flags: record page flag overlays explicitly Andy Whitcroft
2008-05-26 4:37 ` KOSAKI Motohiro [this message]
2008-05-23 16:33 ` [PATCH 2/3] slub: " Andy Whitcroft
2008-05-26 4:40 ` KOSAKI Motohiro
2008-05-27 14:53 ` apw
2008-05-27 16:06 ` KOSAKI Motohiro
2008-05-23 16:33 ` [PATCH 3/3] slob: " Andy Whitcroft
2008-05-26 4:41 ` KOSAKI Motohiro
2008-05-23 17:08 ` [PATCH 0/3] explicitly document overloaded page flags V2 Christoph Lameter
2008-05-26 1:23 ` KAMEZAWA Hiroyuki
-- strict thread matches above, loose matches on Subject: below --
2008-05-15 17:19 [PATCH 0/3] explicitly document overloaded page flags Andy Whitcroft
2008-05-15 17:19 ` [PATCH 1/3] page-flags: record page flag overlays explicitly Andy Whitcroft
2008-05-15 17:28 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526132853.4661.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=clameter@sgi.com \
--cc=jeremy@goop.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox