From: npiggin@suse.de
To: linux-mm@kvack.org
Cc: kniht@us.ibm.com, andi@firstfloor.org, nacc@us.ibm.com,
agl@us.ibm.com, abh@cray.com, joachim.deguara@amd.com,
Andi Kleen <ak@suse.de>
Subject: [patch 02/23] hugetlb: factor out huge_new_page
Date: Mon, 26 May 2008 00:23:19 +1000 [thread overview]
Message-ID: <20080525143452.345341000@nick.local0.net> (raw)
In-Reply-To: <20080525142317.965503000@nick.local0.net>
[-- Attachment #1: hugetlb-factor-page-prep.patch --]
[-- Type: text/plain, Size: 1469 bytes --]
Needed to avoid code duplication in follow up patches.
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
mm/hugetlb.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
Index: linux-2.6/mm/hugetlb.c
===================================================================
--- linux-2.6.orig/mm/hugetlb.c
+++ linux-2.6/mm/hugetlb.c
@@ -194,6 +194,16 @@ static int adjust_pool_surplus(int delta
return ret;
}
+static void prep_new_huge_page(struct page *page, int nid)
+{
+ set_compound_page_dtor(page, free_huge_page);
+ spin_lock(&hugetlb_lock);
+ nr_huge_pages++;
+ nr_huge_pages_node[nid]++;
+ spin_unlock(&hugetlb_lock);
+ put_page(page); /* free it into the hugepage allocator */
+}
+
static struct page *alloc_fresh_huge_page_node(int nid)
{
struct page *page;
@@ -207,12 +217,7 @@ static struct page *alloc_fresh_huge_pag
__free_pages(page, HUGETLB_PAGE_ORDER);
return NULL;
}
- set_compound_page_dtor(page, free_huge_page);
- spin_lock(&hugetlb_lock);
- nr_huge_pages++;
- nr_huge_pages_node[nid]++;
- spin_unlock(&hugetlb_lock);
- put_page(page); /* free it into the hugepage allocator */
+ prep_new_huge_page(page, nid);
}
return page;
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-25 14:23 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-25 14:23 [patch 00/23] multi size, giant hugetlb support, 1GB for x86, 16GB for powerpc npiggin
2008-05-25 14:23 ` [patch 01/23] hugetlb: fix lockdep error npiggin
2008-05-27 16:30 ` Nishanth Aravamudan
2008-05-27 19:55 ` Adam Litke
2008-05-25 14:23 ` npiggin [this message]
2008-05-27 16:31 ` [patch 02/23] hugetlb: factor out huge_new_page Nishanth Aravamudan
2008-05-27 20:03 ` Adam Litke
2008-05-25 14:23 ` [patch 03/23] hugetlb: modular state npiggin
2008-05-27 16:44 ` Nishanth Aravamudan
2008-05-28 8:40 ` Nick Piggin
2008-05-27 20:38 ` Adam Litke
2008-05-28 9:13 ` Nick Piggin
2008-05-25 14:23 ` [patch 04/23] hugetlb: multiple hstates npiggin
2008-05-27 16:52 ` Nishanth Aravamudan
2008-05-27 20:43 ` Adam Litke
2008-05-25 14:23 ` [patch 05/23] hugetlb: multi hstate proc files npiggin
2008-05-29 5:07 ` Nishanth Aravamudan
2008-05-29 5:44 ` Nishanth Aravamudan
2008-05-29 6:30 ` Nishanth Aravamudan
2008-05-29 9:04 ` Nick Piggin
2008-05-25 14:23 ` [patch 06/23] hugetlbfs: per mount hstates npiggin
2008-05-27 16:58 ` Nishanth Aravamudan
2008-05-27 20:50 ` Adam Litke
2008-05-25 14:23 ` [patch 07/23] hugetlb: multi hstate sysctls npiggin
2008-05-27 21:00 ` Adam Litke
2008-05-28 9:59 ` Nick Piggin
2008-05-29 4:59 ` Nishanth Aravamudan
2008-05-29 5:36 ` Nishanth Aravamudan
2008-05-29 8:59 ` Nick Piggin
2008-05-29 6:39 ` [RFC][PATCH 1/2] hugetlb: present information in sysfs Nishanth Aravamudan
2008-05-29 6:42 ` [RFC][PATCH 2/2] hugetlb: remove multi-valued proc files Nishanth Aravamudan
2008-05-30 3:51 ` Nick Piggin
2008-05-30 7:43 ` Nishanth Aravamudan
2008-05-30 2:58 ` [RFC][PATCH 1/2] hugetlb: present information in sysfs Greg KH
2008-05-30 3:37 ` Nick Piggin
2008-05-30 4:21 ` Greg KH
2008-05-30 4:28 ` Nick Piggin
2008-05-30 7:44 ` Nishanth Aravamudan
2008-05-30 7:41 ` Nishanth Aravamudan
2008-05-30 13:40 ` Adam Litke
2008-05-30 7:39 ` Nishanth Aravamudan
2008-05-25 14:23 ` [patch 08/23] hugetlb: abstract numa round robin selection npiggin
2008-05-27 17:01 ` Nishanth Aravamudan
2008-05-27 21:02 ` Adam Litke
2008-05-25 14:23 ` [patch 09/23] mm: introduce non panic alloc_bootmem npiggin
2008-05-25 14:23 ` [patch 10/23] mm: export prep_compound_page to mm npiggin
2008-05-27 21:05 ` Adam Litke
2008-05-25 14:23 ` [patch 11/23] hugetlb: support larger than MAX_ORDER npiggin
2008-05-27 21:23 ` Adam Litke
2008-05-28 10:22 ` Nick Piggin
2008-05-25 14:23 ` [patch 12/23] hugetlb: support boot allocate different sizes npiggin
2008-05-27 17:04 ` Nishanth Aravamudan
2008-05-27 21:28 ` Adam Litke
2008-05-28 10:57 ` Nick Piggin
2008-05-28 14:01 ` Nick Piggin
2008-05-28 14:35 ` Adam Litke
2008-05-25 14:23 ` [patch 13/23] hugetlb: printk cleanup npiggin
2008-05-27 17:05 ` Nishanth Aravamudan
2008-05-27 21:30 ` Adam Litke
2008-05-25 14:23 ` [patch 14/23] hugetlb: introduce huge_pud npiggin
2008-05-26 11:09 ` Hugh Dickins
2008-05-27 2:24 ` Nick Piggin
2008-05-25 14:23 ` [patch 15/23] x86: support GB hugepages on 64-bit npiggin
2008-05-27 21:35 ` Adam Litke
2008-05-25 14:23 ` [patch 16/23] x86: add hugepagesz option " npiggin
2008-05-25 14:23 ` [patch 17/23] hugetlb: do not always register default HPAGE_SIZE huge page size npiggin
2008-05-27 21:39 ` Adam Litke
2008-05-25 14:23 ` [patch 18/23] hugetlb: allow arch overried hugepage allocation npiggin
2008-05-27 21:41 ` Adam Litke
2008-05-25 14:23 ` [patch 19/23] powerpc: function to allocate gigantic hugepages npiggin
2008-05-27 21:44 ` Adam Litke
2008-05-25 14:23 ` [patch 20/23] powerpc: scan device tree for gigantic pages npiggin
2008-05-27 21:47 ` Adam Litke
2008-05-25 14:23 ` [patch 21/23] powerpc: define support for 16G hugepages npiggin
2008-05-25 14:23 ` [patch 22/23] fs: check for statfs overflow npiggin
2008-05-27 17:14 ` Nishanth Aravamudan
2008-05-27 17:19 ` Jon Tollefson
2008-05-28 9:02 ` Nick Piggin
2008-05-29 23:56 ` Andreas Dilger
2008-05-30 0:12 ` Nishanth Aravamudan
2008-05-30 1:14 ` Nick Piggin
2008-06-02 3:16 ` Andreas Dilger
2008-06-03 3:27 ` Nick Piggin
2008-06-03 17:17 ` Andreas Dilger
2008-05-25 14:23 ` [patch 23/23] powerpc: support multiple hugepage sizes npiggin
2008-05-27 17:14 ` Nishanth Aravamudan
2008-05-28 8:49 ` Nick Piggin
2008-05-25 14:42 ` [patch 00/23] multi size, giant hugetlb support, 1GB for x86, 16GB for powerpc Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080525143452.345341000@nick.local0.net \
--to=npiggin@suse.de \
--cc=abh@cray.com \
--cc=agl@us.ibm.com \
--cc=ak@suse.de \
--cc=andi@firstfloor.org \
--cc=joachim.deguara@amd.com \
--cc=kniht@us.ibm.com \
--cc=linux-mm@kvack.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox