From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 15 May 2008 12:34:23 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC/PATCH 2/6] memcg: remove refcnt Message-Id: <20080515123423.db3f79e2.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20080515105740.66e210db.kamezawa.hiroyu@jp.fujitsu.com> References: <20080514170236.23c9ddd7.kamezawa.hiroyu@jp.fujitsu.com> <20080514170703.db2d9802.kamezawa.hiroyu@jp.fujitsu.com> <482B950C.2060408@cn.fujitsu.com> <20080515105740.66e210db.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: Li Zefan , LKML , "linux-mm@kvack.org" , "balbir@linux.vnet.ibm.com" , "xemul@openvz.org" , "yamamoto@valinux.co.jp" , "hugh@veritas.com" , Andrew Morton List-ID: On Thu, 15 May 2008 10:57:40 +0900 KAMEZAWA Hiroyuki wrote: > > > #ifdef CONFIG_DEBUG_VM > > > Index: linux-2.6.26-rc2/mm/shmem.c > > > =================================================================== > > > --- linux-2.6.26-rc2.orig/mm/shmem.c > > > +++ linux-2.6.26-rc2/mm/shmem.c > > > @@ -961,13 +961,14 @@ found: > > > shmem_swp_unmap(ptr); > > > spin_unlock(&info->lock); > > > radix_tree_preload_end(); > > > -uncharge: > > > - mem_cgroup_uncharge_page(page); > > > out: > > > unlock_page(page); > > > page_cache_release(page); > > > iput(inode); /* allows for NULL */ > > > return error; > > > +uncharge: > > > + mem_cgroup_uncharge_cache_page(page); > > > + goto out; > > > } > > > > > > > Seems the logic is changed here. is it intended ? > > > intended. (if success, uncharge is not necessary because there is no refcnt. > I'll add comment. > But, it seems patch 6/6 doesn't seem to be optimal in this case. and have some troubles...I'll find a workaround. It seems that shmem's memcg is complicated... Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org