From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"xemul@openvz.org" <xemul@openvz.org>,
"yamamoto@valinux.co.jp" <yamamoto@valinux.co.jp>,
"hugh@veritas.com" <hugh@veritas.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC/PATCH 4/6] memcg: shmem reclaim helper
Date: Wed, 14 May 2008 17:32:09 +0900 [thread overview]
Message-ID: <20080514173209.860d1c1d.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <482AA16D.7060200@cn.fujitsu.com>
On Wed, 14 May 2008 16:23:09 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> KAMEZAWA Hiroyuki wrote:
> > On Wed, 14 May 2008 16:15:49 +0800
> > Li Zefan <lizf@cn.fujitsu.com> wrote:
> >
> >>> + while(!progress && --retry) {
> >>> + progress = try_to_free_mem_cgroup_pages(mem, gfp_mask);
> >>> + }
> >> This is wrong. How about:
> >> do {
> >> ...
> >> } while (!progress && --retry);
> >>
> > Ouch, or retry--....
> >
>
> retry-- is still wrong, because then after while, retry will be -1, and then:
>
> + if (!retry)
> + return -ENOMEM;
>
ok, i'm now rewriting.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-14 8:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 8:02 [RFC/PATCH 0/6] memcg: peformance improvement at el. v3 KAMEZAWA Hiroyuki
2008-05-14 8:04 ` [RFC/PATCH 1/6] memcg: drop_pages at force_empty KAMEZAWA Hiroyuki
2008-05-14 8:07 ` [RFC/PATCH 2/6] memcg: remove refcnt KAMEZAWA Hiroyuki
2008-05-15 1:42 ` Li Zefan
2008-05-15 1:57 ` KAMEZAWA Hiroyuki
2008-05-15 3:34 ` KAMEZAWA Hiroyuki
2008-05-14 8:08 ` [RFC/PATCH 3/6] memcg: handle swapcache KAMEZAWA Hiroyuki
2008-05-14 8:10 ` [RFC/PATCH 4/6] memcg: shmem reclaim helper KAMEZAWA Hiroyuki
2008-05-14 8:15 ` Li Zefan
2008-05-14 8:25 ` KAMEZAWA Hiroyuki
2008-05-14 8:23 ` Li Zefan
2008-05-14 8:32 ` KAMEZAWA Hiroyuki [this message]
2008-05-14 8:11 ` [RFC/PATCH 5/6] memcg: optimize branch KAMEZAWA Hiroyuki
2008-05-14 8:13 ` [RFC/PATCH 6/6] memcg: remove redundant check at charge KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514173209.860d1c1d.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox