From: Josef Bacik <jbacik@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: jbacik@redhat.com, trond.myklebust@fys.uio.no, npiggin@suse.de,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: NFS infinite loop in filemap_fault()
Date: Thu, 8 May 2008 14:29:47 -0400 [thread overview]
Message-ID: <20080508182947.GB30499@unused.rdu.redhat.com> (raw)
In-Reply-To: <E1JuB47-0008C9-5n@pomaz-ex.szeredi.hu>
On Thu, May 08, 2008 at 08:42:03PM +0200, Miklos Szeredi wrote:
> > > Index: linux.git/mm/filemap.c
> > > ===================================================================
> > > --- linux.git.orig/mm/filemap.c 2008-05-08 08:17:22.000000000 +0200
> > > +++ linux.git/mm/filemap.c 2008-05-08 08:19:59.000000000 +0200
> > > @@ -1461,6 +1461,12 @@ page_not_uptodate:
> > > */
> > > ClearPageError(page);
> > > error = mapping->a_ops->readpage(file, page);
> > > + if (!error && !PageUptodate(page)) {
> >
> > Shouldn't you have (!error || error != AOP_TRUNCATED_PAGE),
>
> That would be a rather useless condition (hint: '!error' means 'error == 0')
>
> > since the fs can
> > return AOP_TRUNCATED_PAGE if it needs vfs to try the readpage again?
>
> Yep, I din't touch the 'error != 0' codepath.
>
Doh sorry, I hadn't had my coffee yet.
Josef
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-05-08 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1JtqLW-0005j5-KU@pomaz-ex.szeredi.hu>
2008-05-08 6:47 ` Miklos Szeredi
2008-05-08 13:07 ` Josef Bacik
2008-05-08 18:42 ` Miklos Szeredi
2008-05-08 18:29 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508182947.GB30499@unused.rdu.redhat.com \
--to=jbacik@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=npiggin@suse.de \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox