From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sun, 4 May 2008 21:25:46 -0500 From: Robin Holt Subject: Re: [PATCH 01 of 11] mmu-notifier-core Message-ID: <20080505022546.GE18857@sgi.com> References: <1489529e7b53d3f2dab8.1209740704@duo.random> <20080504191345.GD18857@sgi.com> <20080504220824.GA21051@duo.random> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080504220824.GA21051@duo.random> Sender: owner-linux-mm@kvack.org Return-Path: To: Andrea Arcangeli Cc: Robin Holt , Andrew Morton , Christoph Lameter , Jack Steiner , Nick Piggin , Peter Zijlstra , kvm-devel@lists.sourceforge.net, Kanoj Sarcar , Roland Dreier , Steve Wise , linux-kernel@vger.kernel.org, Avi Kivity , linux-mm@kvack.org, general@lists.openfabrics.org, Hugh Dickins , Rusty Russell , Anthony Liguori , Chris Wright , Marcelo Tosatti , Eric Dumazet , "Paul E. McKenney" List-ID: On Mon, May 05, 2008 at 12:08:25AM +0200, Andrea Arcangeli wrote: > On Sun, May 04, 2008 at 02:13:45PM -0500, Robin Holt wrote: > > > diff --git a/mm/Kconfig b/mm/Kconfig > > > --- a/mm/Kconfig > > > +++ b/mm/Kconfig > > > @@ -205,3 +205,6 @@ config VIRT_TO_BUS > > > config VIRT_TO_BUS > > > def_bool y > > > depends on !ARCH_NO_VIRT_TO_BUS > > > + > > > +config MMU_NOTIFIER > > > + bool > > > > Without some text following the bool keyword, I am not even asked for > > this config setting on my ia64 build. > > Yes, this was explicitly asked by Andrew after his review. This is the > explanation pasted from the changelog. > > 3) It'd be a waste to add branches in the VM if nobody could possibly > run KVM/GRU/XPMEM on the kernel, so mmu notifiers will only enabled > if CONFIG_KVM=m/y. In the current kernel kvm won't yet take > advantage of mmu notifiers, but this already allows to compile a > KVM external module against a kernel with mmu notifiers enabled and > from the next pull from kvm.git we'll start using them. And > GRU/XPMEM will also be able to continue the development by enabling > KVM=m in their config, until they submit all GRU/XPMEM GPLv2 code > to the mainline kernel. Then they can also enable MMU_NOTIFIERS in > the same way KVM does it (even if KVM=n). This guarantees nobody > selects MMU_NOTIFIER=y if KVM and GRU and XPMEM are all =n. Ah, so Andrew wants users of KVM to do a select of MMU_NOTIFIER. That makes sense. I will change (fix) my Kconfig changes. Thanks, Robin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org