From: Jeremy Kerr <jk@ozlabs.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
jes@trained-monkey.org, cpw@sgi.com
Subject: Re: [patch 3/4] spufs: convert nopfn to fault
Date: Fri, 2 May 2008 16:45:44 +1000 [thread overview]
Message-ID: <200805021645.45165.jk@ozlabs.org> (raw)
In-Reply-To: <20080502050632.GJ11844@wotan.suse.de>
Hi Nick,
> -static unsigned long spufs_mem_mmap_nopfn(struct vm_area_struct
> *vma, - unsigned long address)
> +static int
> +spufs_mem_mmap_fault(struct vm_area_struct *vma, struct vm_fault
> *vmf) {
> struct spu_context *ctx = vma->vm_file->private_data;
> - unsigned long pfn, offset, addr0 = address;
> + unsigned long pfn, offset, address;
> +
> + address = (unsigned long)vmf->virtual_address;
> +
> #ifdef CONFIG_SPU_FS_64K_LS
> struct spu_state *csa = &ctx->csa;
> int psize;
This will add a warning (you're "mixing declarations and code") if
CONFIG_SPU_FS_64K_LS.
Cheers,
Jeremy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-02 6:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 3:19 [patch 0/4] remove nopfn Nick Piggin
2008-05-02 3:20 ` [patch 1/4] mm: allow pfnmap ->fault()s Nick Piggin
2008-05-02 3:21 ` [patch 2/4] mspec: convert nopfn to fault Nick Piggin
2008-05-06 12:27 ` Robin Holt
2008-05-02 3:22 ` [patch 3/4] spufs: " Nick Piggin
2008-05-02 4:06 ` Jeremy Kerr
2008-05-02 4:47 ` Nick Piggin
2008-05-02 9:43 ` Jeremy Kerr
2008-05-03 5:41 ` Nick Piggin
2008-05-06 3:01 ` Jeremy Kerr
2008-05-06 8:38 ` Nick Piggin
2008-05-02 5:06 ` Nick Piggin
2008-05-02 6:45 ` Jeremy Kerr [this message]
2008-05-02 3:23 ` [patch 4/4] mm: remove nopfn Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805021645.45165.jk@ozlabs.org \
--to=jk@ozlabs.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cpw@sgi.com \
--cc=jes@trained-monkey.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox