Re: [patch 17/18] x86: add hugepagesz option on 64-bit

[Andi Kleen <andi@firstfloor.org>]

> If so, I'll hold off
> on any further review.

That's not what I asked for.  Some of your comments were very useful
by pointing to real bugs and other problems, just some others were not. Please 
continue reviewing, just make sure that all the comments are focused on 
improving that particular code in the concrete current application.

For example the bulk of the changes needed for PPC I expect will just be an 
additional add on patchkit.

> > The hugetlbfs code actually doesn't claim that.
> 
> The hugetlb.c code is architecture independent and roughly generic (it
> doesn't know a whole lot about the underlying architecture itself).
> hstates are defined and used in this independent code -- hence my
> perspective that we want to make sure it is flexible enough to handle
> other architectures than x86_64, or at least easily extensible to them.

It is extensible to them, but with some further changes (that is what the 
patchkit claimed)

For power I think it would be best if you just started on the incremental
patches needed (in fact there were already such an addon, perhaps that
can be just improved)

> Well, Nick was talking about adding the powerpc bits to his stack when
> he submited for -mm, so these discussions should be happening now,
> AFAICT.

The whole thing is work in progress and will undoubtedly change more
before it is really used.  Nothing is put in stone yet.

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>