From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 29 Apr 2008 10:43:32 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [RFC][PATCH 4/8] memcg: read_mostly Message-Id: <20080429104332.d469263d.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <48167B22.4060704@cn.fujitsu.com> References: <20080428201900.ae25e086.kamezawa.hiroyu@jp.fujitsu.com> <20080428202652.b00f28da.kamezawa.hiroyu@jp.fujitsu.com> <48167B22.4060704@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Li Zefan Cc: "linux-mm@kvack.org" , "balbir@linux.vnet.ibm.com" , "xemul@openvz.org" , "hugh@veritas.com" , "yamamoto@valinux.co.jp" List-ID: On Tue, 29 Apr 2008 09:34:26 +0800 Li Zefan wrote: > > Index: mm-2.6.25-mm1/mm/memcontrol.c > > =================================================================== > > --- mm-2.6.25-mm1.orig/mm/memcontrol.c > > +++ mm-2.6.25-mm1/mm/memcontrol.c > > @@ -35,9 +35,9 @@ > > > > #include > > > > -struct cgroup_subsys mem_cgroup_subsys; > > -static const int MEM_CGROUP_RECLAIM_RETRIES = 5; > > -static struct kmem_cache *page_cgroup_cache; > > +struct cgroup_subsys mem_cgroup_subsys __read_mostly; > > +static const int MEM_CGROUP_RECLAIM_RETRIES __read_mostly = 5; > > it's not __read_mostly, it's __read_always. ;) > so why not make it a macro: > #define MEM_CGROUP_RECLAIM_RETRIES 5 > I'm not sure why this is not macro ;) I'll change it to macro in next version if no objections. Thanks you for review. -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org