From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"xemul@openvz.org" <xemul@openvz.org>,
"hugh@veritas.com" <hugh@veritas.com>,
"yamamoto@valinux.co.jp" <yamamoto@valinux.co.jp>
Subject: Re: [RFC][PATCH 4/8] memcg: read_mostly
Date: Tue, 29 Apr 2008 10:43:32 +0900 [thread overview]
Message-ID: <20080429104332.d469263d.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <48167B22.4060704@cn.fujitsu.com>
On Tue, 29 Apr 2008 09:34:26 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> > Index: mm-2.6.25-mm1/mm/memcontrol.c
> > ===================================================================
> > --- mm-2.6.25-mm1.orig/mm/memcontrol.c
> > +++ mm-2.6.25-mm1/mm/memcontrol.c
> > @@ -35,9 +35,9 @@
> >
> > #include <asm/uaccess.h>
> >
> > -struct cgroup_subsys mem_cgroup_subsys;
> > -static const int MEM_CGROUP_RECLAIM_RETRIES = 5;
> > -static struct kmem_cache *page_cgroup_cache;
> > +struct cgroup_subsys mem_cgroup_subsys __read_mostly;
> > +static const int MEM_CGROUP_RECLAIM_RETRIES __read_mostly = 5;
>
> it's not __read_mostly, it's __read_always. ;)
> so why not make it a macro:
> #define MEM_CGROUP_RECLAIM_RETRIES 5
>
I'm not sure why this is not macro ;)
I'll change it to macro in next version if no objections.
Thanks you for review.
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-04-29 1:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 11:19 [RFC][PATCH] memcg: performance improvement v2 [0/8] KAMEZAWA Hiroyuki
2008-04-28 11:22 ` [RFC][PATCH 1/8] memcg: migration handling KAMEZAWA Hiroyuki
2008-04-29 1:36 ` Li Zefan
2008-04-29 1:48 ` KAMEZAWA Hiroyuki
2008-04-28 11:23 ` [RFC][PATCH 2/8] memcg: remove refcnt KAMEZAWA Hiroyuki
2008-04-28 11:24 ` [RFC][PATCH 3/8] memcg: swapcache handling retry KAMEZAWA Hiroyuki
2008-04-28 11:26 ` [RFC][PATCH 4/8] memcg: read_mostly KAMEZAWA Hiroyuki
2008-04-29 1:34 ` Li Zefan
2008-04-29 1:43 ` KAMEZAWA Hiroyuki [this message]
2008-04-28 11:28 ` [RFC][PATCH 5/8] memcg: optimize branches KAMEZAWA Hiroyuki
2008-04-29 2:04 ` Li Zefan
2008-04-29 2:48 ` KAMEZAWA Hiroyuki
2008-04-29 3:11 ` KAMEZAWA Hiroyuki
2008-04-28 11:30 ` [RFC][PATCH 6/8] memcg: remove redundant initilization KAMEZAWA Hiroyuki
2008-04-28 11:31 ` [RFC][PATCH 7/8] memcg: remove redundant checks KAMEZAWA Hiroyuki
2008-04-28 11:32 ` [RFC][PATCH 8/8] memcg: inlining mem_cgroup_chage_statistics() KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429104332.d469263d.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox